+ sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     sysfs: don't warn on removal of a nonexistent binary file
has been added to the -mm tree.  Its filename is
     sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: sysfs: don't warn on removal of a nonexistent binary file
From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

This patch (as960) removes the error message and stack dump logged by
sysfs_remove_bin_file() when someone tries to remove a nonexistent file. 
The warning doesn't seem to be needed, since none of the other file-,
symlink-, or directory-removal routines in sysfs complain in a comparable
way.

Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
Acked-by: Tejun Heo <htejun@xxxxxxxxx>
Acked-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/sysfs/bin.c |    7 +------
 1 files changed, 1 insertion(+), 6 deletions(-)

diff -puN fs/sysfs/bin.c~sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file fs/sysfs/bin.c
--- a/fs/sysfs/bin.c~sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file
+++ a/fs/sysfs/bin.c
@@ -248,12 +248,7 @@ int sysfs_create_bin_file(struct kobject
 
 void sysfs_remove_bin_file(struct kobject * kobj, struct bin_attribute * attr)
 {
-	if (sysfs_hash_and_remove(kobj->sd, attr->attr.name) < 0) {
-		printk(KERN_ERR "%s: "
-			"bad dentry or inode or no such file: \"%s\"\n",
-			__FUNCTION__, attr->attr.name);
-		dump_stack();
-	}
+	sysfs_hash_and_remove(kobj->sd, attr->attr.name);
 }
 
 EXPORT_SYMBOL_GPL(sysfs_create_bin_file);
_

Patches currently in -mm which might be from stern@xxxxxxxxxxxxxxxxxxx are

sysfs-dont-warn-on-removal-of-a-nonexistent-binary-file.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux