The patch titled
fbdev: fb_create_modedb() non-static `int first = 1;'
has been added to the -mm tree. Its filename is
fbdev-fb_create_modedb-non-static-int-first-=-1.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: fbdev: fb_create_modedb() non-static `int first = 1;'
From: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
Looking at the code flow, `int first' in fb_create_modedb() should be static.
[adaplas]
Better for 'int first' to be moved outside the loop.
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
Signed-off-by: Antonino Daplas <adaplas@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/video/fbmon.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/video/fbmon.c~fbdev-fb_create_modedb-non-static-int-first-=-1 drivers/video/fbmon.c
--- a/drivers/video/fbmon.c~fbdev-fb_create_modedb-non-static-int-first-=-1
+++ a/drivers/video/fbmon.c
@@ -591,7 +591,9 @@ static struct fb_videomode *fb_create_mo
{
struct fb_videomode *mode, *m;
unsigned char *block;
- int num = 0, i;
+ int num = 0, i, first = 1;
+
+;
mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);
if (mode == NULL)
@@ -608,8 +610,6 @@ static struct fb_videomode *fb_create_mo
DPRINTK(" Detailed Timings\n");
block = edid + DETAILED_TIMING_DESCRIPTIONS_START;
for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) {
- int first = 1;
-
if (!(block[0] == 0x00 && block[1] == 0x00)) {
get_detailed_timing(block, &mode[num]);
if (first) {
_
Patches currently in -mm which might be from Geert.Uytterhoeven@xxxxxxxxxxx are
fbdev-fb_create_modedb-non-static-int-first-=-1.patch
fbdev-fb_create_modedb-non-static-int-first-=-1-fix.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
