The patch titled spi_mpc83xx: support for lsb-first transfers has been added to the -mm tree. Its filename is spi_mpc83xx-support-for-lsb-first-transfers.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: spi_mpc83xx: support for lsb-first transfers From: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx> This controller supports LSB-first transfers; let drivers use them. Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx> Acked-by: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/spi/spi_mpc83xx.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff -puN drivers/spi/spi_mpc83xx.c~spi_mpc83xx-support-for-lsb-first-transfers drivers/spi/spi_mpc83xx.c --- a/drivers/spi/spi_mpc83xx.c~spi_mpc83xx-support-for-lsb-first-transfers +++ a/drivers/spi/spi_mpc83xx.c @@ -153,13 +153,16 @@ static void mpc83xx_spi_chipselect(struc len = len - 1; /* mask out bits we are going to set */ - regval &= ~(SPMODE_CP_BEGIN_EDGECLK | SPMODE_CI_INACTIVEHIGH | - SPMODE_LEN(0xF) | SPMODE_DIV16 | SPMODE_PM(0xF)); + regval &= ~(SPMODE_CP_BEGIN_EDGECLK | SPMODE_CI_INACTIVEHIGH + | SPMODE_LEN(0xF) | SPMODE_DIV16 + | SPMODE_PM(0xF) | SPMODE_REV); if (spi->mode & SPI_CPHA) regval |= SPMODE_CP_BEGIN_EDGECLK; if (spi->mode & SPI_CPOL) regval |= SPMODE_CI_INACTIVEHIGH; + if (!(spi->mode & SPI_LSB_FIRST)) + regval |= SPMODE_REV; regval |= SPMODE_LEN(len); @@ -248,9 +251,11 @@ int mpc83xx_spi_setup_transfer(struct sp regval = mpc83xx_spi_read_reg(&mpc83xx_spi->base->mode); - /* Mask out bits_per_wordgth */ - regval &= ~SPMODE_LEN(0xF); + /* mask out bits we are going to set */ + regval &= ~(SPMODE_LEN(0xF) | SPMODE_REV); regval |= SPMODE_LEN(bits_per_word); + if (!(spi->mode & SPI_LSB_FIRST)) + regval |= SPMODE_REV; /* Turn off SPI unit prior changing mode */ mpc83xx_spi_write_reg(&mpc83xx_spi->base->mode, 0); @@ -260,7 +265,7 @@ int mpc83xx_spi_setup_transfer(struct sp } /* the spi->mode bits understood by this driver: */ -#define MODEBITS (SPI_CPOL | SPI_CPHA | SPI_CS_HIGH) +#define MODEBITS (SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST) static int mpc83xx_spi_setup(struct spi_device *spi) { _ Patches currently in -mm which might be from avorontsov@xxxxxxxxxxxxx are spi_mpc83xx-turn-off-spi-unit-while-switching-mode.patch spi_mpc83xx-get-rid-of-magic-numbers.patch spi_mpc83xx-support-for-lsb-first-transfers.patch spi_mpc83xx-fix-qelsb-mode-shifts.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html