The patch titled netconsole: Use netif_running() in write_msg() has been added to the -mm tree. Its filename is netconsole-use-netif_running-in-write_msg.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: netconsole: Use netif_running() in write_msg() From: Satyam Sharma <satyam@xxxxxxxxxxxxx> Avoid unnecessarily disabling interrupts and calling netpoll_send_udp() if the corresponding local interface is not up. Signed-off-by: Satyam Sharma <satyam@xxxxxxxxxxxxx> Acked-by: Keiichi Kii <k-keiichi@xxxxxxxxxxxxx> Cc: Matt Mackall <mpm@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/net/netconsole.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff -puN drivers/net/netconsole.c~netconsole-use-netif_running-in-write_msg drivers/net/netconsole.c --- a/drivers/net/netconsole.c~netconsole-use-netif_running-in-write_msg +++ a/drivers/net/netconsole.c @@ -75,16 +75,16 @@ static void write_msg(struct console *co int frag, left; unsigned long flags; - local_irq_save(flags); - - for (left = len; left;) { - frag = min(left, MAX_PRINT_CHUNK); - netpoll_send_udp(&np, msg, frag); - msg += frag; - left -= frag; + if (netif_running(np.dev)) { + local_irq_save(flags); + for (left = len; left;) { + frag = min(left, MAX_PRINT_CHUNK); + netpoll_send_udp(&np, msg, frag); + msg += frag; + left -= frag; + } + local_irq_restore(flags); } - - local_irq_restore(flags); } static struct console netconsole = { _ Patches currently in -mm which might be from satyam@xxxxxxxxxxxxx are use-mutex-instead-of-semaphore-in-the-dvb-frontend-tuning-interface.patch netconsole-cleanups-codingstyle-prettyfication.patch netconsole-remove-bogus-check.patch netconsole-simplify-boot-module-option-setup-logic.patch netconsole-use-netif_running-in-write_msg.patch netconsole-add-some-useful-tips-to-documentation.patch netconsole-introduce-netconsole_target.patch netconsole-introduce-netconsole_netdev_notifier.patch netconsole-support-multiple-logging-targets.patch netconsole-support-dynamic-reconfiguration-using-configfs.patch use-mutex-instead-of-semaphore-in-the-onstream-scsi-tape-driver.patch use-mutex-instead-of-semaphore-in-the-scsi-tape-driver.patch use-mutex-instead-of-semaphore-in-the-host-ap-driver.patch use-mutex-instead-of-semaphore-in-isdn-subsystem-common-functions.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html