The patch titled
nfsd4: idmap upcalls should use unsigned uid and gid
has been added to the -mm tree. Its filename is
nfsd4-idmap-upcalls-should-use-unsigned-uid-and-gid.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: nfsd4: idmap upcalls should use unsigned uid and gid
From: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
We shouldn't be using negative uid's and gid's in the idmap upcalls.
Signed-off-by: "J. Bruce Fields" <bfields@xxxxxxxxxxxxxx>
Cc: Neil Brown <neilb@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/nfs4idmap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN fs/nfsd/nfs4idmap.c~nfsd4-idmap-upcalls-should-use-unsigned-uid-and-gid fs/nfsd/nfs4idmap.c
--- a/fs/nfsd/nfs4idmap.c~nfsd4-idmap-upcalls-should-use-unsigned-uid-and-gid
+++ a/fs/nfsd/nfs4idmap.c
@@ -138,7 +138,7 @@ idtoname_request(struct cache_detail *cd
char idstr[11];
qword_add(bpp, blen, ent->authname);
- snprintf(idstr, sizeof(idstr), "%d", ent->id);
+ snprintf(idstr, sizeof(idstr), "%u", ent->id);
qword_add(bpp, blen, ent->type == IDMAP_TYPE_GROUP ? "group" : "user");
qword_add(bpp, blen, idstr);
@@ -165,7 +165,7 @@ idtoname_show(struct seq_file *m, struct
return 0;
}
ent = container_of(h, struct ent, h);
- seq_printf(m, "%s %s %d", ent->authname,
+ seq_printf(m, "%s %s %u", ent->authname,
ent->type == IDMAP_TYPE_GROUP ? "group" : "user",
ent->id);
if (test_bit(CACHE_VALID, &h->flags))
@@ -349,7 +349,7 @@ nametoid_show(struct seq_file *m, struct
ent->type == IDMAP_TYPE_GROUP ? "group" : "user",
ent->name);
if (test_bit(CACHE_VALID, &h->flags))
- seq_printf(m, " %d", ent->id);
+ seq_printf(m, " %u", ent->id);
seq_printf(m, "\n");
return 0;
}
_
Patches currently in -mm which might be from bfields@xxxxxxxxxxxxxx are
origin.patch
knfsd-set-the-response-bitmask-for-nfs4_create_exclusive.patch
nfsd4-idmap-upcalls-should-use-unsigned-uid-and-gid.patch
knfsd-eliminate-unnecessary-enoent-returns-on-export-downcalls.patch
locks-kill-redundant-local-variable.patch
vfs-fix-a-race-in-lease-breaking-during-truncate.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
