The patch titled cpuid driver: implify smp_call_function_single() call sequence has been added to the -mm tree. Its filename is cpuid-driver-simplify-smp_call_function_single-call-sequence.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: cpuid driver: implify smp_call_function_single() call sequence From: Avi Kivity <avi@xxxxxxxxxxxx> smp_call_function_single() now knows how to call the function on the current cpu. Cc: H. Peter Anvin <hpa@xxxxxxxxx> Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx> Cc: Andi Kleen <ak@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/i386/kernel/cpuid.c | 22 +++------------------- 1 files changed, 3 insertions(+), 19 deletions(-) diff -puN arch/i386/kernel/cpuid.c~cpuid-driver-simplify-smp_call_function_single-call-sequence arch/i386/kernel/cpuid.c --- a/arch/i386/kernel/cpuid.c~cpuid-driver-simplify-smp_call_function_single-call-sequence +++ a/arch/i386/kernel/cpuid.c @@ -45,8 +45,6 @@ static struct class *cpuid_class; -#ifdef CONFIG_SMP - struct cpuid_command { u32 reg; u32 *data; @@ -64,25 +62,11 @@ static inline void do_cpuid(int cpu, u32 { struct cpuid_command cmd; - preempt_disable(); - if (cpu == smp_processor_id()) { - cpuid(reg, &data[0], &data[1], &data[2], &data[3]); - } else { - cmd.reg = reg; - cmd.data = data; + cmd.reg = reg; + cmd.data = data; - smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1, 1); - } - preempt_enable(); + smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1, 1); } -#else /* ! CONFIG_SMP */ - -static inline void do_cpuid(int cpu, u32 reg, u32 * data) -{ - cpuid(reg, &data[0], &data[1], &data[2], &data[3]); -} - -#endif /* ! CONFIG_SMP */ static loff_t cpuid_seek(struct file *file, loff_t offset, int orig) { _ Patches currently in -mm which might be from avi@xxxxxxxxxxxx are ia64-allow-smp_call_function_single-to-current-cpu.patch git-kvm.patch cpuid-driver-simplify-smp_call_function_single-call-sequence.patch msr-driver-simplify-smp_call_function_single-call-sequence.patch time-simplify-smp_call_function_single-call-sequence.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html