- spufs-remove-spurious-warn_on-for-spu_deactivate-for-nosched-contexts.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     spufs: remove spurious WARN_ON for spu_deactivate for NOSCHED contexts
has been removed from the -mm tree.  Its filename was
     spufs-remove-spurious-warn_on-for-spu_deactivate-for-nosched-contexts.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: spufs: remove spurious WARN_ON for spu_deactivate for NOSCHED contexts
From: Jeremy Kerr <jk@xxxxxxxxxx>

In 6cbf93960e64f313f6e247cbca7afaa50e3ee2c we added a WARN_ON for calling
spu_deactivate on contexts created with the SPU_CREATE_NOSCHED flag.  However,
all NOSCHED contexts will need to be deactivated when the context is
destroyed, so this gives a spurious warning when any NOSCHED context is
closed.

This change removes the WARN_ON.

Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 arch/powerpc/platforms/cell/spufs/sched.c |    9 ---------
 1 files changed, 9 deletions(-)

diff -puN arch/powerpc/platforms/cell/spufs/sched.c~spufs-remove-spurious-warn_on-for-spu_deactivate-for-nosched-contexts arch/powerpc/platforms/cell/spufs/sched.c
--- a/arch/powerpc/platforms/cell/spufs/sched.c~spufs-remove-spurious-warn_on-for-spu_deactivate-for-nosched-contexts
+++ a/arch/powerpc/platforms/cell/spufs/sched.c
@@ -581,15 +581,6 @@ static int __spu_deactivate(struct spu_c
  */
 void spu_deactivate(struct spu_context *ctx)
 {
-	/*
-	 * We must never reach this for a nosched context,
-	 * but handle the case gracefull instead of panicing.
-	 */
-	if (ctx->flags & SPU_CREATE_NOSCHED) {
-		WARN_ON(1);
-		return;
-	}
-
 	__spu_deactivate(ctx, 1, MAX_PRIO);
 	spuctx_switch_state(ctx, SPUCTX_UTIL_USER);
 }
_

Patches currently in -mm which might be from jk@xxxxxxxxxx are

origin.patch
spufs-make-signal-notification-files-readonly-for-nosched-contexts.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux