The patch titled spufs: make signal-notification files readonly for NOSCHED contexts has been added to the -mm tree. Its filename is spufs-make-signal-notification-files-readonly-for-nosched-contexts.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: spufs: make signal-notification files readonly for NOSCHED contexts From: Jeremy Kerr <jk@xxxxxxxxxx> Reading from the signal{1,2} files requires a spu_acquire_saved, so make these files write-only for contexts created with SPU_CREATE_NOSCHED. Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx> Acked-by: Arnd Bergmann <arnd.bergmann@xxxxxxxxxx> Cc: Paul Mackerras <paulus@xxxxxxxxx> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/powerpc/platforms/cell/spufs/file.c | 18 ++++++++++++++++-- 1 files changed, 16 insertions(+), 2 deletions(-) diff -puN arch/powerpc/platforms/cell/spufs/file.c~spufs-make-signal-notification-files-readonly-for-nosched-contexts arch/powerpc/platforms/cell/spufs/file.c --- a/arch/powerpc/platforms/cell/spufs/file.c~spufs-make-signal-notification-files-readonly-for-nosched-contexts +++ a/arch/powerpc/platforms/cell/spufs/file.c @@ -934,6 +934,13 @@ static const struct file_operations spuf .mmap = spufs_signal1_mmap, }; +static const struct file_operations spufs_signal1_nosched_fops = { + .open = spufs_signal1_open, + .release = spufs_signal1_release, + .write = spufs_signal1_write, + .mmap = spufs_signal1_mmap, +}; + static int spufs_signal2_open(struct inode *inode, struct file *file) { struct spufs_inode_info *i = SPUFS_I(inode); @@ -1062,6 +1069,13 @@ static const struct file_operations spuf .mmap = spufs_signal2_mmap, }; +static const struct file_operations spufs_signal2_nosched_fops = { + .open = spufs_signal2_open, + .release = spufs_signal2_release, + .write = spufs_signal2_write, + .mmap = spufs_signal2_mmap, +}; + static void spufs_signal1_type_set(void *data, u64 val) { struct spu_context *ctx = data; @@ -2184,8 +2198,8 @@ struct tree_descr spufs_dir_nosched_cont { "mbox_stat", &spufs_mbox_stat_fops, 0444, }, { "ibox_stat", &spufs_ibox_stat_fops, 0444, }, { "wbox_stat", &spufs_wbox_stat_fops, 0444, }, - { "signal1", &spufs_signal1_fops, 0666, }, - { "signal2", &spufs_signal2_fops, 0666, }, + { "signal1", &spufs_signal1_nosched_fops, 0222, }, + { "signal2", &spufs_signal2_nosched_fops, 0222, }, { "signal1_type", &spufs_signal1_type, 0666, }, { "signal2_type", &spufs_signal2_type, 0666, }, { "mss", &spufs_mss_fops, 0666, }, _ Patches currently in -mm which might be from jk@xxxxxxxxxx are origin.patch spufs-avoid-unexpectedly-restaring-mfc-during-context-save.patch spufs-make-signal-notification-files-readonly-for-nosched-contexts.patch spufs-remove-spurious-warn_on-for-spu_deactivate-for-nosched-contexts.patch spufs-add-spu-stats-in-sysfs-and-ctx-stat-file-in-spufs.patch spufs-make-sure-context-are-scheduled-again-after-spu_acquire_saved.patch spufs-fix-array-size-of-channel-index.patch spufs-remove-needless-context-save-restore-code.patch spufs-fix-decr_status-meanings.patch spufs-fix-read-and-write-for-decr_status-file.patch spufs-limit-saving-mfc_cntl-bits.patch spufs-dont-halt-decrementer-at-restore-step-47.patch spufs-change-decrementer-restore-timing.patch spufs-remove-unused-file-argument-from-spufs_run_spu.patch spufs-use-find_first_bit-instead-of-sched_find_first_bit.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html