The patch titled
usb: mos7720, mos7840: remove redundant urb check
has been added to the -mm tree. Its filename is
usb-mos7720-mos7840-remove-redundant-urb-check.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: usb: mos7720, mos7840: remove redundant urb check
From: Florin Malita <fmalita@xxxxxxxxx>
Coverity (1709, 1710, 1711, 1712, 1713) actually flagged these as
REVERSE_INULLs (NULL check performed after dereference). But looking at
the other drivers I can't see any similar tests and the USB core already
makes sure urb is non-null - so might as well get rid of the checks.
Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/usb/serial/mos7720.c | 5 -----
drivers/usb/serial/mos7840.c | 19 -------------------
2 files changed, 24 deletions(-)
diff -puN drivers/usb/serial/mos7720.c~usb-mos7720-mos7840-remove-redundant-urb-check drivers/usb/serial/mos7720.c
--- a/drivers/usb/serial/mos7720.c~usb-mos7720-mos7840-remove-redundant-urb-check
+++ a/drivers/usb/serial/mos7720.c
@@ -110,11 +110,6 @@ static void mos7720_interrupt_callback(s
dbg("%s"," : Entering\n");
- if (!urb) {
- dbg("%s","Invalid Pointer !!!!:\n");
- return;
- }
-
switch (status) {
case 0:
/* success */
diff -puN drivers/usb/serial/mos7840.c~usb-mos7720-mos7840-remove-redundant-urb-check drivers/usb/serial/mos7840.c
--- a/drivers/usb/serial/mos7840.c~usb-mos7720-mos7840-remove-redundant-urb-check
+++ a/drivers/usb/serial/mos7840.c
@@ -436,11 +436,6 @@ static void mos7840_control_callback(str
int result = 0;
int status = urb->status;
- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-
mos7840_port = (struct moschip_port *)urb->context;
switch (status) {
@@ -525,10 +520,6 @@ static void mos7840_interrupt_callback(s
int status = urb->status;
dbg("%s", " : Entering\n");
- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
switch (status) {
case 0:
@@ -676,11 +667,6 @@ static void mos7840_bulk_in_callback(str
struct tty_struct *tty;
int status = urb->status;
- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-
if (status) {
dbg("nonzero read bulk status received: %d", status);
return;
@@ -753,11 +739,6 @@ static void mos7840_bulk_out_data_callba
int status = urb->status;
int i;
- if (!urb) {
- dbg("%s", "Invalid Pointer !!!!:\n");
- return;
- }
-
mos7840_port = (struct moschip_port *)urb->context;
spin_lock(&mos7840_port->pool_lock);
for (i = 0; i < NUM_URBS; i++) {
_
Patches currently in -mm which might be from fmalita@xxxxxxxxx are
origin.patch
usb-mos7720-mos7840-remove-redundant-urb-check.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
