The patch titled
ata: fix reported task file values in sense data
has been added to the -mm tree. Its filename is
ata-fix-reported-task-file-values-in-sense-data.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ata: fix reported task file values in sense data
From: Petr Vandrovec <petr@xxxxxxxxxxxxxx>
ata_tf_read was setting HOB bit when lba48 command was submitted, but was
not clearing it before reading "normal" data. As it is only place which
sets HOB bit in control register, and register reads should not be affected
by other bits, let's just clear it when we are done with reading upper
bytes so non-48bit commands do not have to touch ctl at all.
pata_scc suffered from same problem...
Signed-off-by: Petr Vandrovec <petr@xxxxxxxxxxxxxx>
Cc: Jeff Garzik <jeff@xxxxxxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: Tejun Heo <htejun@xxxxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/ata/libata-sff.c | 2 ++
drivers/ata/pata_scc.c | 2 ++
2 files changed, 4 insertions(+)
diff -puN drivers/ata/libata-sff.c~ata-fix-reported-task-file-values-in-sense-data drivers/ata/libata-sff.c
--- a/drivers/ata/libata-sff.c~ata-fix-reported-task-file-values-in-sense-data
+++ a/drivers/ata/libata-sff.c
@@ -211,6 +211,8 @@ void ata_tf_read(struct ata_port *ap, st
tf->hob_lbal = ioread8(ioaddr->lbal_addr);
tf->hob_lbam = ioread8(ioaddr->lbam_addr);
tf->hob_lbah = ioread8(ioaddr->lbah_addr);
+ iowrite8(tf->ctl, ioaddr->ctl_addr);
+ ap->last_ctl = tf->ctl;
}
}
diff -puN drivers/ata/pata_scc.c~ata-fix-reported-task-file-values-in-sense-data drivers/ata/pata_scc.c
--- a/drivers/ata/pata_scc.c~ata-fix-reported-task-file-values-in-sense-data
+++ a/drivers/ata/pata_scc.c
@@ -358,6 +358,8 @@ static void scc_tf_read (struct ata_port
tf->hob_lbal = in_be32(ioaddr->lbal_addr);
tf->hob_lbam = in_be32(ioaddr->lbam_addr);
tf->hob_lbah = in_be32(ioaddr->lbah_addr);
+ out_be32(ioaddr->ctl_addr, tf->ctl);
+ ap->last_ctl = tf->ctl;
}
}
_
Patches currently in -mm which might be from petr@xxxxxxxxxxxxxx are
origin.patch
ata-fix-reported-task-file-values-in-sense-data.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
