The patch titled Remove workaround for unimmunized rcu_dereference from mce_log() has been added to the -mm tree. Its filename is remove-workaround-for-unimmunized-rcu_dereference-from-mce_log.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: Remove workaround for unimmunized rcu_dereference from mce_log() From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> Remove the rmb() from mce_log(), since the immunized version of rcu_dereference() makes it unnecessary. Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> Cc: Ingo Molnar <mingo@xxxxxxx> Cc: Andi Kleen <ak@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/x86_64/kernel/mce.c | 3 --- 1 files changed, 3 deletions(-) diff -puN arch/x86_64/kernel/mce.c~remove-workaround-for-unimmunized-rcu_dereference-from-mce_log arch/x86_64/kernel/mce.c --- a/arch/x86_64/kernel/mce.c~remove-workaround-for-unimmunized-rcu_dereference-from-mce_log +++ a/arch/x86_64/kernel/mce.c @@ -76,9 +76,6 @@ void mce_log(struct mce *mce) wmb(); for (;;) { entry = rcu_dereference(mcelog.next); - /* The rmb forces the compiler to reload next in each - iteration */ - rmb(); for (;;) { /* When the buffer fills up discard new entries. Assume that the earlier errors are the more interesting. */ _ Patches currently in -mm which might be from paulmck@xxxxxxxxxxxxxxxxxx are document-the-fact-that-rcu-callbacks-can-run-in-parallel.patch immunize-rcu_dereference-against-crazy-compiler-writers.patch remove-workaround-for-unimmunized-rcu_dereference-from-mce_log.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html