- fs-introduce-write_begin-write_end-and-perform_write-aops-fix-5.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     new aop block_write_begin fix
has been removed from the -mm tree.  Its filename was
     fs-introduce-write_begin-write_end-and-perform_write-aops-fix-5.patch

This patch was dropped because it was folded into fs-introduce-write_begin-write_end-and-perform_write-aops.patch

------------------------------------------------------
Subject: new aop block_write_begin fix
From: Dmitriy Monakhov <dmonakhov@xxxxx>

After we enter to block_write_begin with *pagep == NULL and some page was
grabed we remember this page in *pagep And if __block_prepare_write() we
have to clear *pagep , as it was before.  Because this may confuse caller. 
for example caller may have folowing code:

 		ret = block_write_begin(..., pagep,...)
 		if (ret && *pagep != NULL) {
 			unlock_page(*pagep);
 			page_cache_release(*pagep);
 		}

Signed-off-by: Dmitriy Monakhov <dmonakhov@xxxxxxxxxx>
Cc: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/buffer.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN fs/buffer.c~fs-introduce-write_begin-write_end-and-perform_write-aops-fix-5 fs/buffer.c
--- a/fs/buffer.c~fs-introduce-write_begin-write_end-and-perform_write-aops-fix-5
+++ a/fs/buffer.c
@@ -1951,6 +1951,7 @@ int block_write_begin(struct file *file,
 		if (ownpage) {
 			unlock_page(page);
 			page_cache_release(page);
+			*pagep = NULL;
 
 			/*
 			 * prepare_write() may have instantiated a few blocks
_

Patches currently in -mm which might be from dmonakhov@xxxxx are

fs-introduce-write_begin-write_end-and-perform_write-aops.patch
fs-introduce-write_begin-write_end-and-perform_write-aops-fix-5.patch
ext3-convert-to-new-aops-fix.patch
ext4-convert-to-new-aops-fix.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux