The patch titled blink: only blink when parameter is set has been removed from the -mm tree. Its filename was blink-only-blink-when-parameter-is-set.patch This patch was dropped because it is obsolete ------------------------------------------------------ Subject: blink: only blink when parameter is set From: Bernhard Walle <bwalle@xxxxxxx> This patch in the blink driver changes the module to only blink when the parameter 'blink' is set to true. This is to allow the module to be compiled in the kernel and not as module. As the blink module was initially written for kdump, and as the kernel is relocatable on lots of architectures, there's no need to compile a separate kdump kernel. The blinking can now enabled via the boot command line for the kdump kernel when necessary. The patch also adds some author/license information and marks the init function as '__init'. Signed-off-by: Bernhard Walle <bwalle@xxxxxxx> Cc: Andi Kleen <ak@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/misc/blink.c | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-) diff -puN drivers/misc/blink.c~blink-only-blink-when-parameter-is-set drivers/misc/blink.c --- a/drivers/misc/blink.c~blink-only-blink-when-parameter-is-set +++ a/drivers/misc/blink.c @@ -3,6 +3,10 @@ #include <linux/timer.h> #include <linux/jiffies.h> +static int blink; +module_param(blink, bool, S_IRUGO); +MODULE_PARM_DESC(blink, "Enable blinking (without that, the module does nothing)"); + static void do_blink(unsigned long data); static DEFINE_TIMER(blink_timer, do_blink, 0 ,0); @@ -16,12 +20,19 @@ static void do_blink(unsigned long data) add_timer(&blink_timer); } -static int blink_init(void) +static int __init blink_init(void) { printk(KERN_INFO "Enabling keyboard blinking\n"); - do_blink(0); + + if (blink) + do_blink(0); + return 0; } module_init(blink_init); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Andi Kleen <ak@xxxxxxx>"); +MODULE_DESCRIPTION("Blinks the keyboard LEDs"); + _ Patches currently in -mm which might be from bwalle@xxxxxxx are strip-config_-automatically-in-kernel-configuration-search.patch git-netdev-all.patch git-scsi-misc.patch blink-only-blink-when-parameter-is-set.patch blink-only-blink-when-parameter-is-set-fix.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html