The patch titled
ads7846: SPI_CPHA mode bugfix
has been added to the -mm tree. Its filename is
ads7846-spi_cpha-mode-bugfix.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ads7846: SPI_CPHA mode bugfix
From: Semih Hazar <semih.hazar@xxxxxxxxxxx>
In commit [1] the SPI mode is set to 1, but it should be 0. As stated in the
commit, ads784x samples the data on the rising edge. SPI mode 1 samples on
the falling edge [2] though.
The root cause of this is a bug in the omap_uwire code, which treats
CPHA=1 incorrectly; so these two bugs cancel each other out on one
of the main regression test platforms for this driver.
[1] kernel.org GIT 7937e86a70235e1584486654687dc9908a11e00a
[2] http://en.wikipedia.org/wiki/Serial_Peripheral_Interface_Bus
Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/input/touchscreen/ads7846.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/input/touchscreen/ads7846.c~ads7846-spi_cpha-mode-bugfix drivers/input/touchscreen/ads7846.c
--- a/drivers/input/touchscreen/ads7846.c~ads7846-spi_cpha-mode-bugfix
+++ a/drivers/input/touchscreen/ads7846.c
@@ -847,7 +847,7 @@ static int __devinit ads7846_probe(struc
* may not. So we stick to very-portable 8 bit words, both RX and TX.
*/
spi->bits_per_word = 8;
- spi->mode = SPI_MODE_1;
+ spi->mode = SPI_MODE_0;
err = spi_setup(spi);
if (err < 0)
return err;
_
Patches currently in -mm which might be from semih.hazar@xxxxxxxxxxx are
ads7846-spi_cpha-mode-bugfix.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
