The patch titled
MM: alloc_large_system_hash() can free some memory for non power-of-two bucketsize
has been removed from the -mm tree. Its filename was
mm-alloc_large_system_hash-can-free-some-memory-for-non.patch
This patch was dropped because it had testing failures
------------------------------------------------------
Subject: MM: alloc_large_system_hash() can free some memory for non power-of-two bucketsize
From: Eric Dumazet <dada1@xxxxxxxxxxxxx>
alloc_large_system_hash() is called at boot time to allocate space for
several large hash tables.
Lately, TCP hash table was changed and its bucketsize is not a power-of-two
anymore.
On most setups, alloc_large_system_hash() allocates one big page (order >
0) with __get_free_pages(GFP_ATOMIC, order). This single high_order page
has a power-of-two size, bigger than the needed size.
We can free all pages that wont be used by the hash table.
On a 1GB i386 machine, this patch saves 128 KB of LOWMEM memory.
TCP established hash table entries: 32768 (order: 6, 393216 bytes)
Signed-off-by: Eric Dumazet <dada1@xxxxxxxxxxxxx>
Cc: Mel Gorman <mel@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/page_alloc.c | 14 ++++++++++++++
1 files changed, 14 insertions(+)
diff -puN mm/page_alloc.c~mm-alloc_large_system_hash-can-free-some-memory-for-non mm/page_alloc.c
--- a/mm/page_alloc.c~mm-alloc_large_system_hash-can-free-some-memory-for-non
+++ a/mm/page_alloc.c
@@ -3578,6 +3578,20 @@ void *__init alloc_large_system_hash(con
for (order = 0; ((1UL << order) << PAGE_SHIFT) < size; order++)
;
table = (void*) __get_free_pages(GFP_ATOMIC, order);
+ /*
+ * If bucketsize is not a power-of-two, we may free
+ * some pages at the end of hash table.
+ */
+ if (table) {
+ unsigned long alloc_end = (unsigned long)table +
+ (PAGE_SIZE << order);
+ unsigned long used = (unsigned long)table +
+ PAGE_ALIGN(size);
+ while (used < alloc_end) {
+ free_page(used);
+ used += PAGE_SIZE;
+ }
+ }
}
} while (!table && size > PAGE_SIZE && --log2qty);
_
Patches currently in -mm which might be from dada1@xxxxxxxxxxxxx are
mm-alloc_large_system_hash-can-free-some-memory-for-non.patch
lguest-the-host-code.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
