+ kconfig-powernow-k8-driver-should-depend-on-acpi-p-states-driver.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Kconfig powernow-k8 driver should depend on ACPI P-States driver
has been added to the -mm tree.  Its filename is
     kconfig-powernow-k8-driver-should-depend-on-acpi-p-states-driver.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: Kconfig powernow-k8 driver should depend on ACPI P-States driver
From: Joshua Hoblitt <jhoblitt@xxxxxxxxxxxxxx>

Below is a one line patch to possibly fix this bug:

http://bugs.gentoo.org/show_bug.cgi?id=178585
http://bugzilla.kernel.org/show_bug.cgi?id=8075

If the kernel is configured with:

CONFIG_X86_POWERNOW_K8=y
CONFIG_X86_ACPI_CPUFREQ=m

Which is currently an allowed configuration, the powernow-k8 driver on
an SMP system will fail with a warning like:

powernow-k8: Found 4 Dual Core AMD Opteron(tm) Processor 285 processors (version 2.00.00)
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure
powernow-k8: MP systems not supported by PSB BIOS structure

Which mimics that failure you get when powernow/cool'n'quiet is disabled
in the BIOS.  I don't know if this config combination is valid on a
uniprocessor system so this dependency may need to be enforced only if
SMP in enabled.  The other powernow-* drivers likely have the same
requirements as -k8 but I am unable to test them.

Signed-off-by: Joshua Hoblitt <jhoblitt@xxxxxxxxxxxxxx>
Cc: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
Cc: Len Brown <lenb@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 arch/i386/kernel/cpu/cpufreq/Kconfig |    1 +
 1 files changed, 1 insertion(+)

diff -puN arch/i386/kernel/cpu/cpufreq/Kconfig~kconfig-powernow-k8-driver-should-depend-on-acpi-p-states-driver arch/i386/kernel/cpu/cpufreq/Kconfig
--- a/arch/i386/kernel/cpu/cpufreq/Kconfig~kconfig-powernow-k8-driver-should-depend-on-acpi-p-states-driver
+++ a/arch/i386/kernel/cpu/cpufreq/Kconfig
@@ -82,6 +82,7 @@ config X86_POWERNOW_K8
 	tristate "AMD Opteron/Athlon64 PowerNow!"
 	select CPU_FREQ_TABLE
 	depends on EXPERIMENTAL
+	depends on X86_ACPI_CPUFREQ
 	help
 	  This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.
 
_

Patches currently in -mm which might be from jhoblitt@xxxxxxxxxxxxxx are

kconfig-powernow-k8-driver-should-depend-on-acpi-p-states-driver.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux