+ usb-core-hubc-loops-forever-on-resume-from-ram-due-to.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     usb/core/hub.c loops forever on resume from ram due to  bluetooth
has been added to the -mm tree.  Its filename is
     usb-core-hubc-loops-forever-on-resume-from-ram-due-to.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: usb/core/hub.c loops forever on resume from ram due to  bluetooth
From: Mark Lord <lkml@xxxxxx>

The root cause here was a missing CONFIG_USB_SUSPEND=y, which means the
hci_usb device never got marked as USB_STATE_SUSPENDED, which then caused
the loop to go on forever.

The system works fine now with CONFIG_USB_SUSPEND=y in the .config.

Here's the patch to prevent future lockups for this or other causes.  I no
longer need it, but it does still seem a good idea.

Signed-off-by:  Mark Lord <mlord@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/usb/core/hub.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/usb/core/hub.c~usb-core-hubc-loops-forever-on-resume-from-ram-due-to drivers/usb/core/hub.c
--- a/drivers/usb/core/hub.c~usb-core-hubc-loops-forever-on-resume-from-ram-due-to
+++ a/drivers/usb/core/hub.c
@@ -400,9 +400,10 @@ static void hub_tt_kevent (struct work_s
 	struct usb_hub		*hub =
 		container_of(work, struct usb_hub, tt.kevent);
 	unsigned long		flags;
+	int			limit = 100;
 
 	spin_lock_irqsave (&hub->tt.lock, flags);
-	while (!list_empty (&hub->tt.clear_list)) {
+	while (--limit && !list_empty (&hub->tt.clear_list)) {
 		struct list_head	*temp;
 		struct usb_tt_clear	*clear;
 		struct usb_device	*hdev = hub->hdev;
_

Patches currently in -mm which might be from lkml@xxxxxx are

usb-core-hubc-loops-forever-on-resume-from-ram-due-to.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux