The patch titled timer: revert parenthesis fix in tbase_get_deferrable() etc has been removed from the -mm tree. Its filename was timer-revert-parenthesis-fix-in-tbase_get_deferrable-etc.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ Subject: timer: revert parenthesis fix in tbase_get_deferrable() etc From: Jarek Poplawski <jarkao2@xxxxx> > > On 09-05-2007 21:10, Pallipadi, Venkatesh wrote: > > ... > > > On a 64 bit system, converting pointer to int causes unnecessary > > > compiler > > > warning, and intermediate long conversion was to avoid that. I will have > > > to rephrase my comment to remove 32 bit value and use int, as that is > > > what > > > the function returns. So, this patch reverts all changes done by my previous patch. I apologize for my wrong comment about "logical error" here. Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@xxxxxxxxx> Cc: Satyam Sharma <satyam.sharma@xxxxxxxxx> Cc: Oleg Nesterov <oleg@xxxxxxxxxx> Signed-off-by: Jarek Poplawski <jarkao2@xxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/timer.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN kernel/timer.c~timer-revert-parenthesis-fix-in-tbase_get_deferrable-etc kernel/timer.c --- a/kernel/timer.c~timer-revert-parenthesis-fix-in-tbase_get_deferrable-etc +++ a/kernel/timer.c @@ -92,24 +92,24 @@ static DEFINE_PER_CPU(tvec_base_t *, tve /* Functions below help us manage 'deferrable' flag */ static inline unsigned int tbase_get_deferrable(tvec_base_t *base) { - return (unsigned int)((unsigned long)base & TBASE_DEFERRABLE_FLAG); + return ((unsigned int)(unsigned long)base & TBASE_DEFERRABLE_FLAG); } static inline tvec_base_t *tbase_get_base(tvec_base_t *base) { - return (tvec_base_t *)((unsigned long)base & ~TBASE_DEFERRABLE_FLAG); + return ((tvec_base_t *)((unsigned long)base & ~TBASE_DEFERRABLE_FLAG)); } static inline void timer_set_deferrable(struct timer_list *timer) { - timer->base = (tvec_base_t *)((unsigned long)timer->base | - TBASE_DEFERRABLE_FLAG); + timer->base = ((tvec_base_t *)((unsigned long)(timer->base) | + TBASE_DEFERRABLE_FLAG)); } static inline void timer_set_base(struct timer_list *timer, tvec_base_t *new_base) { - timer->base = (tvec_base_t *)((unsigned long)new_base | + timer->base = (tvec_base_t *)((unsigned long)(new_base) | tbase_get_deferrable(timer->base)); } _ Patches currently in -mm which might be from jarkao2@xxxxx are origin.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html