The patch titled
AFS: fix interminable loop in afs_write_back_from_locked_page()
has been added to the -mm tree. Its filename is
afs-fix-interminable-loop-in-afs_write_back_from_locked_page.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: AFS: fix interminable loop in afs_write_back_from_locked_page()
From: David Howells <dhowells@xxxxxxxxxx>
Following bug was uncovered by compiling with '-W' flag:
CC [M] fs/afs/write.o
fs/afs/write.c: In function â??afs_write_back_from_locked_pageâ??:
fs/afs/write.c:398: warning: comparison of unsigned expression >= 0 is always true
Loop variable 'n' is unsigned, so wraps around happily as far as I can
see. Trival fix attached (compile tested only).
Signed-off-by: Mika Kukkonen <mikukkon@xxxxxx>
Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/afs/write.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -puN fs/afs/write.c~afs-fix-interminable-loop-in-afs_write_back_from_locked_page fs/afs/write.c
--- a/fs/afs/write.c~afs-fix-interminable-loop-in-afs_write_back_from_locked_page
+++ a/fs/afs/write.c
@@ -395,8 +395,9 @@ static int afs_write_back_from_locked_pa
if (n == 0)
goto no_more;
if (pages[0]->index != start) {
- for (n--; n >= 0; n--)
- put_page(pages[n]);
+ do {
+ put_page(pages[--n]);
+ } while (n > 0);
goto no_more;
}
_
Patches currently in -mm which might be from dhowells@xxxxxxxxxx are
origin.patch
nommu-present-backing-device-capabilities-for-mtd.patch
nommu-add-support-for-direct-mapping-through-mtdconcat.patch
nommu-generalise-the-handling-of-mtd-specific-superblocks.patch
nommu-make-it-possible-for-romfs-to-use-mtd-devices.patch
romfs-printk-format-warnings.patch
git-net.patch
afs-fix-interminable-loop-in-afs_write_back_from_locked_page.patch
afs-fix-a-couple-of-problems-with-unlinking-afs-files.patch
introduce-freezer-flags-rev-2.patch
frv-gdb-use-__maybe_unused.patch
mutex-subsystem-synchro-test-module.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
