The patch titled spi: fix use of set_cs in spi_s3c24xx driver has been added to the -mm tree. Its filename is spi-fix-use-of-set_cs-in-spi_s3c24xx-driver.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: spi: fix use of set_cs in spi_s3c24xx driver From: Ben Dooks <ben-linux-arm@xxxxxxxxx> It turns out that the last patch to change set_cs to be kept in the controller's structure instead of the platform data was an incomplete change, and did not change the references to platfrom data in the setup xfer code. (This can prevent an oops.) Reported-by: <Ling.Alex@xxxxxxxxxx> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/spi/spi_s3c24xx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/spi/spi_s3c24xx.c~spi-fix-use-of-set_cs-in-spi_s3c24xx-driver drivers/spi/spi_s3c24xx.c --- a/drivers/spi/spi_s3c24xx.c~spi-fix-use-of-set_cs-in-spi_s3c24xx-driver +++ a/drivers/spi/spi_s3c24xx.c @@ -77,7 +77,7 @@ static void s3c24xx_spi_chipsel(struct s switch (value) { case BITBANG_CS_INACTIVE: - hw->pdata->set_cs(hw->pdata, spi->chip_select, cspol^1); + hw->set_cs(hw->pdata, spi->chip_select, cspol^1); break; case BITBANG_CS_ACTIVE: @@ -98,7 +98,7 @@ static void s3c24xx_spi_chipsel(struct s /* write new configration */ writeb(spcon, hw->regs + S3C2410_SPCON); - hw->pdata->set_cs(hw->pdata, spi->chip_select, cspol); + hw->set_cs(hw->pdata, spi->chip_select, cspol); break; } _ Patches currently in -mm which might be from ben-linux-arm@xxxxxxxxx are spi-fix-use-of-set_cs-in-spi_s3c24xx-driver.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html