The patch titled Remove redundant check from proc_setattr() has been added to the -mm tree. Its filename is remove-redundant-check-from-proc_setattr.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: Remove redundant check from proc_setattr() From: John Johansen <jjohansen@xxxxxxx> notify_change() already calls security_inode_setattr() before calling iop->setattr. Signed-off-by: Tony Jones <tonyj@xxxxxxx> Signed-off-by: Andreas Gruenbacher <agruen@xxxxxxx> Signed-off-by: John Johansen <jjohansen@xxxxxxx> Cc: Stephen Smalley <sds@xxxxxxxxxxxxx> Cc: James Morris <jmorris@xxxxxxxxx> Cc: Chris Wright <chrisw@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/proc/base.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff -puN fs/proc/base.c~remove-redundant-check-from-proc_setattr fs/proc/base.c --- a/fs/proc/base.c~remove-redundant-check-from-proc_setattr +++ a/fs/proc/base.c @@ -344,11 +344,8 @@ static int proc_setattr(struct dentry *d return -EPERM; error = inode_change_ok(inode, attr); - if (!error) { - error = security_inode_setattr(dentry, attr); - if (!error) - error = inode_setattr(inode, attr); - } + if (!error) + error = inode_setattr(inode, attr); return error; } _ Patches currently in -mm which might be from jjohansen@xxxxxxx are remove-redundant-check-from-proc_setattr.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html