+ slub-fix-numa-bootstrap.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     SLUB: Fix numa bootstrap
has been added to the -mm tree.  Its filename is
     slub-fix-numa-bootstrap.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: SLUB: Fix numa bootstrap
From: Christoph Lameter <clameter@xxxxxxx>

NUMA bootstrap calls new_slab() if more than one node is found on bootup. 
new_slab() assumes a standard slab context where interrupts must be
disabled.  It enables interrupts for the call into the page allocator and
then disables them again.  Interrupts do not have to be disabled during on
bootstrap because we still run single threaded there.

I dropped the interrupt preservation code just before SLUB v6 because it
looked useless there.  SLUB worked on the following NUMA tests that just
had a single node.  Sigh.

Enable interrupts after calling new_slab.

Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 mm/slub.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN mm/slub.c~slub-fix-numa-bootstrap mm/slub.c
--- a/mm/slub.c~slub-fix-numa-bootstrap
+++ a/mm/slub.c
@@ -1436,6 +1436,8 @@ static int init_kmem_cache_nodes(struct 
 
 			BUG_ON(s->size < sizeof(struct kmem_cache_node));
 			page = new_slab(kmalloc_caches, gfpflags, node);
+			/* new_slab() disables interupts */
+			local_irq_enable();
 
 			BUG_ON(!page);
 			n = page->freelist;
_

Patches currently in -mm which might be from clameter@xxxxxxx are

slab-introduce-krealloc.patch
slab-introduce-krealloc-fix.patch
safer-nr_node_ids-and-nr_node_ids-determination-and-initial.patch
use-zvc-counters-to-establish-exact-size-of-dirtyable-pages.patch
slab-ensure-cache_alloc_refill-terminates.patch
smaps-extract-pmd-walker-from-smaps-code.patch
smaps-add-pages-referenced-count-to-smaps.patch
smaps-add-clear_refs-file-to-clear-reference.patch
smaps-add-clear_refs-file-to-clear-reference-fix.patch
smaps-add-clear_refs-file-to-clear-reference-fix-fix.patch
slab-use-num_possible_cpus-in-enable_cpucache.patch
slub-core.patch
slub-fix-numa-bootstrap.patch
slub-add-slabinfo-tool.patch
extend-print_symbol-capability-fix.patch
slab-shutdown-cache_reaper-when-cpu-goes-down.patch
mm-implement-swap-prefetching.patch
readahead-state-based-method-aging-accounting.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux