The patch titled
uevent-improve-error-checking-and-handling fix
has been removed from the -mm tree. Its filename was
uevent-improve-error-checking-and-handling-fix.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
Subject: uevent-improve-error-checking-and-handling fix
From: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
The firmware class tried to suppress the first KOBJ_ADD uevent by
returning -ENODEV in firmware_uevent if FW_STATUS_READY was not set.
This only worked as long as the return code of kobject_uevent was not
checked in device_add. hack-to-make-wireless-work.patch made that first
uevent return successfully, but this possible triggered some udev rule
too early, leading to firmware load failures.
The following patch uses uevent_suppress to stop the uevent from being
generated during device_add.
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/base/firmware_class.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/base/firmware_class.c~uevent-improve-error-checking-and-handling-fix drivers/base/firmware_class.c
--- a/drivers/base/firmware_class.c~uevent-improve-error-checking-and-handling-fix
+++ a/drivers/base/firmware_class.c
@@ -333,6 +333,7 @@ static int fw_register_device(struct dev
f_dev->parent = device;
f_dev->class = &firmware_class;
dev_set_drvdata(f_dev, fw_priv);
+ f_dev->uevent_suppress = 1;
retval = device_register(f_dev);
if (retval) {
printk(KERN_ERR "%s: device_register failed\n",
@@ -385,6 +386,7 @@ static int fw_setup_device(struct firmwa
set_bit(FW_STATUS_READY, &fw_priv->status);
else
set_bit(FW_STATUS_READY_NOHOTPLUG, &fw_priv->status);
+ f_dev->uevent_suppress = 0;
*dev_p = f_dev;
goto out;
_
Patches currently in -mm which might be from cornelia.huck@xxxxxxxxxx are
origin.patch
driver-core-suppress-uevents-via-filter.patch
driver-core-switch-firmware_class-to.patch
s390-cio-delay-uevents-for-subchannels.patch
git-s390.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
