- dev_printk-and-new-style-class-devices.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     dev_printk and new-style class devices
has been removed from the -mm tree.  Its filename was
     dev_printk-and-new-style-class-devices.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: dev_printk and new-style class devices
From: Jean Delvare <khali@xxxxxxxxxxxx>

As the new-style class devices (as opposed to old-style struct
class_device) are becoming more widely used, I noticed that the
dev_printk-based functions are not working properly with these.  New-style
class devices have no driver nor bus, almost by definition, and as a result
dev_driver_string(), which is used as the first parameter of dev_printk,
resolves to an empty string.  This causes entries like the following to
show in my logs:

 i2c-2: adapter [SMBus stub driver] registered

Notice the unaesthetical leading whitespace.  In order to fix this problem,
I suggest that we extend dev_driver_string to deal with new-style class
devices:

Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/base/core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/base/core.c~dev_printk-and-new-style-class-devices drivers/base/core.c
--- a/drivers/base/core.c~dev_printk-and-new-style-class-devices
+++ a/drivers/base/core.c
@@ -57,7 +57,8 @@ bool is_lanana_major(unsigned int major)
 const char *dev_driver_string(struct device *dev)
 {
 	return dev->driver ? dev->driver->name :
-			(dev->bus ? dev->bus->name : "");
+			(dev->bus ? dev->bus->name :
+			(dev->class ? dev->class->name : ""));
 }
 EXPORT_SYMBOL(dev_driver_string);
 
_

Patches currently in -mm which might be from khali@xxxxxxxxxxxx are

sound-strlcpy-is-smart-enough.patch
git-dvb.patch
ehea-strlcpy-is-smart-enough.patch
git-s390.patch
blackfin-blackfin-i2c-driver-update-2.patch
xtensa-strlcpy-is-smart-enough.patch
oss-strlcpy-is-smart-enough.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux