The patch titled as: fix antic_expire check has been added to the -mm tree. Its filename is as-fix-antic_expire-check.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: as: fix antic_expire check From: Nick Piggin <nickpiggin@xxxxxxxxxxxx> Fix units mismatch (jiffies vs msecs) in as-iosched.c, spotted by Xiaoning Ding <dingxn@xxxxxxxxxxxxxxxxxx>. Signed-off-by: Nick Piggin <npiggin@xxxxxxx> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- block/as-iosched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN block/as-iosched.c~as-fix-antic_expire-check block/as-iosched.c --- a/block/as-iosched.c~as-fix-antic_expire-check +++ a/block/as-iosched.c @@ -569,7 +569,7 @@ static void as_update_iohist(struct as_d static int as_close_req(struct as_data *ad, struct as_io_context *aic, struct request *rq) { - unsigned long delay; /* milliseconds */ + unsigned long delay; /* jiffies */ sector_t last = ad->last_sector[ad->batch_data_dir]; sector_t next = rq->sector; sector_t delta; /* acceptable close offset (in sectors) */ @@ -578,11 +578,11 @@ static int as_close_req(struct as_data * if (ad->antic_status == ANTIC_OFF || !ad->ioc_finished) delay = 0; else - delay = ((jiffies - ad->antic_start) * 1000) / HZ; + delay = jiffies - ad->antic_start; if (delay == 0) delta = 8192; - else if (delay <= 20 && delay <= ad->antic_expire) + else if (delay <= (20 * HZ / 1000) && delay <= ad->antic_expire) delta = 8192 << delay; else return 1; _ Patches currently in -mm which might be from nickpiggin@xxxxxxxxxxxx are dio-invalidate-clean-pages-before-dio-write.patch cpuset-remove-sched-domain-hooks-from-cpusets.patch freezer-task-exit_state-should-be-treated-as-bolean.patch splice-partial-write-handling-fix.patch as-fix-antic_expire-check.patch kblockd-use-flush_work.patch sched-fix-idle-load-balancing-in-softirqd-context.patch sched-dynticks-idle-load-balancing-v3.patch sched-optimize-siblings-status-check-logic-in-wake_idle.patch lists-add-list-splice-tail.patch sched-remove-sleepavg-from-proc.patch sched-remove-noninteractive-flag.patch sched-implement-180-bit-sched-bitmap.patch sched-dont-renice-kernel-threads.patch sched-implement-rsdl-cpu-scheduler.patch sched-implement-rsdl-cpu-scheduler-accounting-fixes.patch sched-document-rsdl-cpu-scheduler.patch sched2-sched-domain-sysctl.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html