The patch titled drivers/char/synclink.c: check kmalloc() return value has been added to the -mm tree. Its filename is drivers-char-synclinkc-check-kmalloc-return-value.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: drivers/char/synclink.c: check kmalloc() return value From: Amit Choudhary <amit2030@xxxxxxxxx> Signed-off-by: Amit Choudhary <amit2030@xxxxxxxxx> Cc: Paul Fulghum <paulkf@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/synclink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff -puN drivers/char/synclink.c~drivers-char-synclinkc-check-kmalloc-return-value drivers/char/synclink.c --- a/drivers/char/synclink.c~drivers-char-synclinkc-check-kmalloc-return-value +++ a/drivers/char/synclink.c @@ -4010,8 +4010,13 @@ static int mgsl_alloc_intermediate_txbuf for ( i=0; i<info->num_tx_holding_buffers; ++i) { info->tx_holding_buffers[i].buffer = kmalloc(info->max_frame_size, GFP_KERNEL); - if ( info->tx_holding_buffers[i].buffer == NULL ) + if (info->tx_holding_buffers[i].buffer == NULL) { + for (--i; i >= 0; i--) { + kfree(info->tx_holding_buffers[i].buffer); + info->tx_holding_buffers[i].buffer = NULL; + } return -ENOMEM; + } } return 0; _ Patches currently in -mm which might be from amit2030@xxxxxxxxx are drivers-char-synclinkc-check-kmalloc-return-value.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html