The patch titled IRQ: add __must_check to request_irq has been added to the -mm tree. Its filename is irq-add-__must_check-to-request_irq.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: IRQ: add __must_check to request_irq From: Monakhov Dmitriy <dmonakhov@xxxxxxxxxx> This could help to find buggy drivers where request_irq return value wasn't checked. There's just no reason to ignore errors which can and do occur. Anyone who got warning during compilation have to realise what it is't realy safe code. Signed-off-by: Monakhov Dmitriy <dmonakhov@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/interrupt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN include/linux/interrupt.h~irq-add-__must_check-to-request_irq include/linux/interrupt.h --- a/include/linux/interrupt.h~irq-add-__must_check-to-request_irq +++ a/include/linux/interrupt.h @@ -83,11 +83,11 @@ struct irqaction { }; extern irqreturn_t no_action(int cpl, void *dev_id); -extern int request_irq(unsigned int, irq_handler_t handler, +extern int __must_check request_irq(unsigned int, irq_handler_t handler, unsigned long, const char *, void *); extern void free_irq(unsigned int, void *); -extern int devm_request_irq(struct device *dev, unsigned int irq, +extern int __must_check devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler, unsigned long irqflags, const char *devname, void *dev_id); extern void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id); _ Patches currently in -mm which might be from dmonakhov@xxxxxxxxxx are ecryptfs-set-o_largefile-when-opening-lower-file.patch ecryptfs-remove-unnecessary-flush_dcache_page.patch ecryptfs-no-path_release-after-path_lookup-error.patch libata-handle-ata_pci_device_do_resume-failure-while-resuming-v2.patch 3c59x-handle-pci_enable_device-failure-while-resuming.patch sk98lin-handle-pci_enable_device-return-value-in-skge_resume.patch mpt-fusion-handle-mpt_resume-failure-while-resuming.patch freevxfs-possible-null-pointer-dereference-fix.patch reiserfs-possible-null-pointer-dereference-during-resize.patch irq-add-__must_check-to-request_irq.patch ecryptfs-handles-aop_truncated_page-better.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html