The patch titled kconfig: abort configuration with recursive dependencies has been added to the -mm tree. Its filename is kconfig-abort-configuration-with-recursive-dependencies.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: kconfig: abort configuration with recursive dependencies From: Adrian Bunk <bunk@xxxxxxxxx> A recursive kconfig dependency is a bug that has to be fixed, and that might currently not be noted until booting the built kernel. Currently, the warning that a recursive dependency was detected scrolls away during "make oldconfig", and often people don't notice until they booted the kernel and note something like "Why is there no IPV6 support?". This patch therefore lets the configuration fail if kconfig found a recursive dependency. Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> Cc: Roman Zippel <zippel@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/kconfig/symbol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN scripts/kconfig/symbol.c~kconfig-abort-configuration-with-recursive-dependencies scripts/kconfig/symbol.c --- a/scripts/kconfig/symbol.c~kconfig-abort-configuration-with-recursive-dependencies +++ a/scripts/kconfig/symbol.c @@ -792,7 +792,7 @@ struct symbol *sym_check_deps(struct sym struct property *prop; if (sym->flags & SYMBOL_CHECK) { - printf("Warning! Found recursive dependency: %s", sym->name); + printf("Error: Found recursive dependency: %s", sym->name); return sym; } if (sym->flags & SYMBOL_CHECKED) @@ -820,7 +820,7 @@ out: printf(" %s", sym->name); if (sym2 == sym) { printf("\n"); - sym2 = NULL; + exit(1); } } sym->flags &= ~SYMBOL_CHECK; _ Patches currently in -mm which might be from bunk@xxxxxxxxx are arch-arm26-kernel-entrys-remove-dead-code.patch make-ipc-shmcshm_nopage-static.patch mm-tiny-shmemc-cleanups.patch drivers-video-sm501fbc-make-4-functions-static.patch fix-the-sysctl=n-compilation.patch remove-the-jffs-maintainers-entry.patch drivers-isdn-gigaset-build-asyncdatao-into-the-gigaset-module-fix.patch git-cpufreq.patch make-kernel-kmodckmod_mk-static.patch git-drm.patch git-dvb.patch make-dvb_usb_gl861_debug-static.patch make-pvr2_encoder_prep_config-static.patch git-ieee1394.patch kconfig-abort-configuration-with-recursive-dependencies.patch mips-remove-smp_tune_scheduling.patch drivers-mmc-kconfig-source-drivers-mmc-card-kconfig.patch remove-fs-jffs2-ioctlc.patch git-ubi.patch mtd_ubi_debug-must-depend-on-sysfs.patch drivers-net-vioc-possible-cleanups.patch git-net.patch net-uninline-skb_put-fix.patch drivers-scsi-small-cleanups.patch drivers-scsi-advansysc-cleanups.patch megaraid-fix-warnings-when-config_proc_fs=n.patch drivers-scsi-dpt_i2oc-remove-dead-code.patch drivers-scsi-aic7xxx-make-functions-static.patch drivers-scsi-wd33c93c-cleanups.patch drivers-scsi-qla4xxx-possible-cleanups.patch make-seagate_st0x_detect-static.patch drivers-scsi-aacraid-cleanups.patch remove-the-broken-scsi_acornscsi_3-driver.patch git-unionfs.patch make-drivers-usb-misc-iowarriorciowarrior_ids-static.patch git-ipwireless_cs.patch arch-i386-kernel-alternativec-should-include-asm-bugsh.patch make-struct-vmi_ops-static.patch i386-asm-offsetsc-workaround-for-a-wmissing-prototypes-warning.patch lguest-kconfig-and-headers-fix.patch proper-prototype-for-hugetlb_get_unmapped_area.patch mm-slabc-proper-prototypes.patch lumpy-reclaim-cleanup.patch filesystem-disk-errors-at-boot-time-caused-by-probe-fix.patch kill-net-rxrpc-rxrpc_symsc.patch drivers-char-hvc_consolec-cleanups.patch init-do_mountsc-proper-prepare_namespace-prototype.patch make-ext2_get_blocks-static.patch drivers-edac-make-code-static.patch linux-kernel-markers-kconfig-menus-fix.patch linux-kernel-markers-architecture-independant-code-license-fix.patch linux-kernel-markers-i386-optimization-export-fix.patch readahead-events-accounting-make-readahead_debug_level-static.patch reiser4-export-remove_from_page_cache-fix.patch fs-reiser4-possible-cleanups.patch reiser4-possible-cleanups-2.patch fs-reiser4-possible-cleanups-2.patch fs-reiser4-more-possible-cleanups.patch slim-main-patch-security-slim-slm_mainc-make-2-functions-static.patch slim-debug-output-slm_set_taskperm-remove-horrible-error-handling-code.patch i386-enable-4k-stacks-by-default.patch mutex-subsystem-synchro-test-module.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html