The patch titled
uml: mostly const a structure
has been removed from the -mm tree. Its filename was
uml-mostly-const-a-structure.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: uml: mostly const a structure
From: Jeff Dike <jdike@xxxxxxxxxxx>
The chan_opts structure is mostly const, and needs no locking. Comment the
lack of locking on the one field that can change.
Make all the other fields const. It turned out that console_open_chan didn't
use its chan_opts argument, so that is deleted from the function and its
callers.
Signed-off-by: Jeff Dike <jdike@xxxxxxxxxxx>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
arch/um/drivers/chan_kern.c | 5 ++---
arch/um/drivers/ssl.c | 3 ++-
arch/um/drivers/stdio_console.c | 3 ++-
arch/um/include/chan_kern.h | 3 +--
arch/um/include/chan_user.h | 8 ++++----
5 files changed, 11 insertions(+), 11 deletions(-)
diff -puN arch/um/drivers/chan_kern.c~uml-mostly-const-a-structure arch/um/drivers/chan_kern.c
--- a/arch/um/drivers/chan_kern.c~uml-mostly-const-a-structure
+++ a/arch/um/drivers/chan_kern.c
@@ -354,8 +354,7 @@ int console_write_chan(struct list_head
return ret;
}
-int console_open_chan(struct line *line, struct console *co,
- const struct chan_opts *opts)
+int console_open_chan(struct line *line, struct console *co)
{
int err;
@@ -363,7 +362,7 @@ int console_open_chan(struct line *line,
if(err)
return err;
- printk("Console initialized on /dev/%s%d\n",co->name,co->index);
+ printk("Console initialized on /dev/%s%d\n", co->name, co->index);
return 0;
}
diff -puN arch/um/drivers/ssl.c~uml-mostly-const-a-structure arch/um/drivers/ssl.c
--- a/arch/um/drivers/ssl.c~uml-mostly-const-a-structure
+++ a/arch/um/drivers/ssl.c
@@ -38,6 +38,7 @@ static void ssl_announce(char *dev_name,
dev_name);
}
+/* Almost const, except that xterm_title may be changed in an initcall */
static struct chan_opts opts = {
.announce = ssl_announce,
.xterm_title = "Serial Line #%d",
@@ -171,7 +172,7 @@ static int ssl_console_setup(struct cons
{
struct line *line = &serial_lines[co->index];
- return console_open_chan(line, co, &opts);
+ return console_open_chan(line, co);
}
static struct console ssl_cons = {
diff -puN arch/um/drivers/stdio_console.c~uml-mostly-const-a-structure arch/um/drivers/stdio_console.c
--- a/arch/um/drivers/stdio_console.c~uml-mostly-const-a-structure
+++ a/arch/um/drivers/stdio_console.c
@@ -42,6 +42,7 @@ void stdio_announce(char *dev_name, int
dev_name);
}
+/* Almost const, except that xterm_title may be changed in an initcall */
static struct chan_opts opts = {
.announce = stdio_announce,
.xterm_title = "Virtual Console #%d",
@@ -144,7 +145,7 @@ static int uml_console_setup(struct cons
{
struct line *line = &vts[co->index];
- return console_open_chan(line, co, &opts);
+ return console_open_chan(line, co);
}
static struct console stdiocons = {
diff -puN arch/um/include/chan_kern.h~uml-mostly-const-a-structure arch/um/include/chan_kern.h
--- a/arch/um/include/chan_kern.h~uml-mostly-const-a-structure
+++ a/arch/um/include/chan_kern.h
@@ -36,8 +36,7 @@ extern int write_chan(struct list_head *
int write_irq);
extern int console_write_chan(struct list_head *chans, const char *buf,
int len);
-extern int console_open_chan(struct line *line, struct console *co,
- const struct chan_opts *opts);
+extern int console_open_chan(struct line *line, struct console *co);
extern void deactivate_chan(struct list_head *chans, int irq);
extern void reactivate_chan(struct list_head *chans, int irq);
extern void chan_enable_winch(struct list_head *chans, struct tty_struct *tty);
diff -puN arch/um/include/chan_user.h~uml-mostly-const-a-structure arch/um/include/chan_user.h
--- a/arch/um/include/chan_user.h~uml-mostly-const-a-structure
+++ a/arch/um/include/chan_user.h
@@ -9,11 +9,11 @@
#include "init.h"
struct chan_opts {
- void (*announce)(char *dev_name, int dev);
+ void (*const announce)(char *dev_name, int dev);
char *xterm_title;
- int raw;
- unsigned long tramp_stack;
- int in_kernel;
+ const int raw;
+ const unsigned long tramp_stack;
+ const int in_kernel;
};
enum chan_init_pri { INIT_STATIC, INIT_ALL, INIT_ONE };
_
Patches currently in -mm which might be from jdike@xxxxxxxxxxx are
origin.patch
uml-fix-prototypes.patch
dynamic-kernel-command-line-common.patch
dynamic-kernel-command-line-um.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
