The patch titled
fs: fix __block_write_full_page error case buffer submission
has been added to the -mm tree. Its filename is
fs-fix-__block_write_full_page-error-case-buffer-submission.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: fs: fix __block_write_full_page error case buffer submission
From: Nick Piggin <npiggin@xxxxxxx>
Andrew noticed that unlocking the page before submitting all buffers for
writeout could cause problems if the IO completes before we've finished
messing around with the page buffers, and they subsequently get freed.
Even if there were no bug, it is a good idea to bring the error case
into line with the common case here.
Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/buffer.c~fs-fix-__block_write_full_page-error-case-buffer-submission fs/buffer.c
--- a/fs/buffer.c~fs-fix-__block_write_full_page-error-case-buffer-submission
+++ a/fs/buffer.c
@@ -1741,7 +1741,6 @@ recover:
SetPageError(page);
BUG_ON(PageWriteback(page));
set_page_writeback(page);
- unlock_page(page);
do {
struct buffer_head *next = bh->b_this_page;
if (buffer_async_write(bh)) {
@@ -1751,6 +1750,7 @@ recover:
}
bh = next;
} while (bh != head);
+ unlock_page(page);
goto done;
}
_
Patches currently in -mm which might be from npiggin@xxxxxxx are
git-block.patch
mm-vm_insert_pfn.patch
mm-vm_insert_pfn-tidy.patch
buffer-memorder-fix.patch
fs-fix-__block_write_full_page-error-case-buffer-submission.patch
sched-avoid-div-in-rebalance_tick.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
