The patch titled allow-access-to-proc-pid-fd-after-setuid-v2 has been added to the -mm tree. Its filename is allow-access-to-proc-pid-fd-after-setuid-update.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: allow-access-to-proc-pid-fd-after-setuid-v2 From: Alexey Dobriyan <adobriyan@xxxxxxxxxx> crap, Pavel reminded that get_proc_task() can return NULL. Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxxx> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> Cc: James Morris <jmorris@xxxxxxxxx> Cc: Chris Wright <chrisw@xxxxxxxxxxxx> Cc: Ulrich Drepper <drepper@xxxxxxxxxx> Cc: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Kirill Korotaev <dev@xxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- fs/proc/base.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff -puN fs/proc/base.c~allow-access-to-proc-pid-fd-after-setuid-update fs/proc/base.c --- a/fs/proc/base.c~allow-access-to-proc-pid-fd-after-setuid-update +++ a/fs/proc/base.c @@ -1427,9 +1427,11 @@ static int proc_fd_permission(struct ino if (rv == 0) return 0; tsk = get_proc_task(inode); - if (tsk == current) - rv = 0; - put_task_struct(tsk); + if (tsk) { + if (tsk == current) + rv = 0; + put_task_struct(tsk); + } return rv; } _ Patches currently in -mm which might be from adobriyan@xxxxxxxxxx are revert-x86_64-mm-msr-on-cpu.patch rdmsr_on_cpu-wrmsr_on_cpu.patch p4-clockmod-use-rdmsr_on_cpu-wrmsr_on_cpu.patch sysctl_ms_jiffies-fix-oldlen-semantics.patch consolidate-default-sched_clock.patch fix-rmmod-read-write-races-in-proc-entries.patch sn2-use-static-proc_fops.patch consolidate-bust_spinlocks.patch extract-and-use-wake_up_klogd.patch allow-access-to-proc-pid-fd-after-setuid.patch allow-access-to-proc-pid-fd-after-setuid-fix.patch allow-access-to-proc-pid-fd-after-setuid-update.patch lutimesat-simplify-utime2.patch lutimesat-extend-do_utimes-with-flags.patch lutimesat-actual-syscall-and-wire-up-on-i386.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html