The patch titled
minimize lockdep_on/off side-effect
has been added to the -mm tree. Its filename is
minimize-lockdep_on-off-side-effect.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: minimize lockdep_on/off side-effect
From: Mathieu Desnoyers <compudj@xxxxxxxxxxxxxxxxxx>
Minimize lockdep_on/off side-effect on irq tracing in vprintk by using
raw_local_irq_save/restore _around_ lockdep_off/on().
It has the advantage of not losing the IRQ events coming between the lockdep
disabling and the irq disabling.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/printk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN kernel/printk.c~minimize-lockdep_on-off-side-effect kernel/printk.c
--- a/kernel/printk.c~minimize-lockdep_on-off-side-effect
+++ a/kernel/printk.c
@@ -529,8 +529,8 @@ asmlinkage int vprintk(const char *fmt,
zap_locks();
/* This stops the holder of console_sem just where we want him */
+ raw_local_irq_save(flags);
lockdep_off();
- local_irq_save(flags);
spin_lock(&logbuf_lock);
printk_cpu = smp_processor_id();
@@ -617,8 +617,8 @@ asmlinkage int vprintk(const char *fmt,
console_locked = 0;
up(&console_sem);
}
- local_irq_restore(flags);
lockdep_on();
+ raw_local_irq_restore(flags);
} else {
/*
* Someone else owns the drivers. We drop the spinlock, which
@@ -627,8 +627,8 @@ asmlinkage int vprintk(const char *fmt,
*/
printk_cpu = UINT_MAX;
spin_unlock(&logbuf_lock);
- local_irq_restore(flags);
lockdep_on();
+ raw_local_irq_restore(flags);
}
preempt_enable();
_
Patches currently in -mm which might be from compudj@xxxxxxxxxxxxxxxxxx are
order-of-lockdep-off-on-in-vprintk-should-be-changed.patch
minimize-lockdep_on-off-side-effect.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
