The patch titled fix the toshiba_acpi write_lcd return value has been added to the -mm tree. Its filename is fix-the-toshiba_acpi-write_lcd-return-value.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: fix the toshiba_acpi write_lcd return value From: Matthijs van Otterdijk <thotter@xxxxxxxxx> write_lcd() in toshiba_acpi returns 0 on success since the big ACPI patch merged in 2.6.20-rc2. It should return count. Signed-off-by: Matthijs van Otterdijk <thotter@xxxxxxxxx> Cc: Len Brown <lenb@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/acpi/toshiba_acpi.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff -puN drivers/acpi/toshiba_acpi.c~fix-the-toshiba_acpi-write_lcd-return-value drivers/acpi/toshiba_acpi.c --- a/drivers/acpi/toshiba_acpi.c~fix-the-toshiba_acpi-write_lcd-return-value +++ a/drivers/acpi/toshiba_acpi.c @@ -321,13 +321,16 @@ static int set_lcd_status(struct backlig static unsigned long write_lcd(const char *buffer, unsigned long count) { int value; - int ret = count; + int ret; if (sscanf(buffer, " brightness : %i", &value) == 1 && - value >= 0 && value < HCI_LCD_BRIGHTNESS_LEVELS) + value >= 0 && value < HCI_LCD_BRIGHTNESS_LEVELS) { ret = set_lcd(value); - else + if (ret == 0) + ret = count; + } else { ret = -EINVAL; + } return ret; } _ Patches currently in -mm which might be from thotter@xxxxxxxxx are fix-the-toshiba_acpi-write_lcd-return-value.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html