Re: [merged mm-nonmm-stable] checkpatch-add-warning-for-pr_-and-dev_-macros-without-a-trailing-newline.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2025-03-16 at 23:09 -0700, Andrew Morton wrote:
> On Sun, 16 Mar 2025 22:51:53 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:
> 
> > > One false warning that will be generated due to this change is in case we
> > > have a patch that modifies a `pr_* call without a newline` which has a
> > > pr_cont with a newline following it.  In this case there will be a warning
> > > but because the patch does not include the following pr_cont it will warn
> > > there is nothing creating a newline.  I have modified the warning to be
> > > softer due to this known problem.
> > 
> > I think this patch is a merely a conversion of one defect for another
> > and it's quite compilcated code too.
> 
> Well darn, it would have been nice to receive this review during the
> review!
> 
> Should I drop the patch?

I don't think it's particularly valuable or useful. 






[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux