The patch titled
Subject: sysctl: fix underflow value setting risk in vm_table
has been added to the -mm mm-nonmm-unstable branch. Its filename is
sysctl-fix-underflow-value-setting-risk-in-vm_table.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/sysctl-fix-underflow-value-setting-risk-in-vm_table.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Nicolas Bouchinet <nicolas.bouchinet@xxxxxxxxxxx>
Subject: sysctl: fix underflow value setting risk in vm_table
Date: Wed, 15 Jan 2025 14:22:09 +0100
Commit 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in
vm_table") fixes underflow value setting risk in vm_table but misses
vdso_enabled sysctl.
vdso_enabled sysctl is initialized with .extra1 value as SYSCTL_ZERO to
avoid negative value writes but the proc_handler is proc_dointvec and not
proc_dointvec_minmax and thus do not uses .extra1 and .extra2.
The following command thus works :
`# echo -1 > /proc/sys/vm/vdso_enabled`
This patch properly sets the proc_handler to proc_dointvec_minmax. In
addition to .extra1, .extra2 is set to SYSCTL_ONE. The sysctl is thus
bounded between 0 and 1.
Link: https://lkml.kernel.org/r/20250115132211.25400-3-nicolas.bouchinet@xxxxxxxxxxx
Fixes: 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in vm_table")
Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@xxxxxxxxxxx>
Reviewed-by: Jan Kara <jack@xxxxxxx>
Reviewed-by: Kees Cook <kees@xxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Christian Brauner <brauner@xxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>
Cc: Joel Granados <j.granados@xxxxxxxxxxx>
Cc: Lin Feng <linf@xxxxxxxxxx>
Cc: Luis Chamberalin <mcgrof@xxxxxxxxxx>
Cc: "Neil Horman" <nhorman@xxxxxxxxxxxxx>
Cc: Nicolas Bouchinet <nicolas.bouchinet@xxxxxxxxxxx>
Cc: Ted Ts'o <tytso@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
0 files changed
_
Patches currently in -mm which might be from nicolas.bouchinet@xxxxxxxxxxx are
coredump-fixes-core_pipe_limit-sysctl-proc_handler.patch
sysctl-fix-underflow-value-setting-risk-in-vm_table.patch
