The patch titled Subject: ocfs2: support large folios in ocfs2_zero_cluster_folios() has been added to the -mm mm-nonmm-unstable branch. Its filename is ocfs2-support-large-folios-in-ocfs2_zero_cluster_folios.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/ocfs2-support-large-folios-in-ocfs2_zero_cluster_folios.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Mark Tinguely <mark.tinguely@xxxxxxxxxx> Subject: ocfs2: support large folios in ocfs2_zero_cluster_folios() Date: Thu, 5 Dec 2024 17:16:50 +0000 Remove assumptions that a folio is one page in size. Link: https://lkml.kernel.org/r/20241205171653.3179945-23-willy@xxxxxxxxxxxxx Signed-off-by: Mark Tinguely <mark.tinguely@xxxxxxxxxx> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Reviewed-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx> Cc: Changwei Ge <gechangwei@xxxxxxx> Cc: Joel Becker <jlbec@xxxxxxxxxxxx> Cc: Jun Piao <piaojun@xxxxxxxxxx> Cc: Junxiao Bi <junxiao.bi@xxxxxxxxxx> Cc: Mark Fasheh <mark@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ocfs2/alloc.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) --- a/fs/ocfs2/alloc.c~ocfs2-support-large-folios-in-ocfs2_zero_cluster_folios +++ a/fs/ocfs2/alloc.c @@ -6851,7 +6851,6 @@ static void ocfs2_zero_cluster_folios(st u64 phys, handle_t *handle) { int i; - unsigned int from, to = PAGE_SIZE; struct super_block *sb = inode->i_sb; BUG_ON(!ocfs2_sparse_alloc(OCFS2_SB(sb))); @@ -6859,21 +6858,18 @@ static void ocfs2_zero_cluster_folios(st if (numfolios == 0) goto out; - to = PAGE_SIZE; for (i = 0; i < numfolios; i++) { struct folio *folio = folios[i]; + size_t to = folio_size(folio); + size_t from = offset_in_folio(folio, start); - from = start & (PAGE_SIZE - 1); - if ((end >> PAGE_SHIFT) == folio->index) - to = end & (PAGE_SIZE - 1); - - BUG_ON(from > PAGE_SIZE); - BUG_ON(to > PAGE_SIZE); + if (to > end - folio_pos(folio)) + to = end - folio_pos(folio); ocfs2_map_and_dirty_folio(inode, handle, from, to, folio, 1, &phys); - start = (folio->index + 1) << PAGE_SHIFT; + start = folio_next_index(folio) << PAGE_SHIFT; } out: if (folios) _ Patches currently in -mm which might be from mark.tinguely@xxxxxxxxxx are ocfs2-convert-w_target_page-to-w_target_folio.patch ocfs2-use-a-folio-in-ocfs2_zero_new_buffers.patch ocfs2-use-a-folio-in-ocfs2_write_begin_inline.patch ocfs2-convert-ocfs2_readpage_inline-to-take-a-folio.patch ocfs2-convert-ocfs2_inode_lock_with_page-to-ocfs2_inode_lock_with_folio.patch ocfs2-convert-w_pages-to-w_folios.patch ocfs2-convert-ocfs2_write_failure-to-use-a-folio.patch ocfs2-use-a-folio-in-ocfs2_write_end_nolock.patch ocfs2-use-a-folio-in-ocfs2_prepare_page_for_write.patch ocfs2-use-a-folio-in-ocfs2_map_and_dirty_page.patch ocfs2-convert-ocfs2_map_page_blocks-to-ocfs2_map_folio_blocks.patch ocfs2-convert-ocfs2_clear_page_regions-to-ocfs2_clear_folio_regions.patch ocfs2-use-an-array-of-folios-instead-of-an-array-of-pages.patch ocfs2-convert-ocfs2_duplicate_clusters_by_page-to-use-a-folio.patch ocfs2-convert-ocfs2_map_and_dirty_page-to-ocfs2_map_and_dirty_folio.patch ocfs2-support-large-folios-in-ocfs2_zero_cluster_folios.patch ocfs2-support-large-folios-in-ocfs2_write_zero_page.patch