On (24/12/15 16:57), caiqingfu wrote: > as you said: > > zram cannot ensure that, it's not zram's job. Nothing stops > > the buggy actor from modifiying the page at any random point, > > It is not zram's job to ensure that data is not modified. > As long as there is re-compression, it must be confirmed again > whether the length has changed. zram recompression will go away soon, I just need to finish my old series and send it out. > This way we can avoid zrampanic caused by upper layer problems. > So I think this patch should not be discarded. Sorry, I diagree. That's not the right place to fix that problem, that's not the right way to fix that problem. There are numerous block devices that set BLK_FEAT_STABLE_WRITES bit, we should not patch all those drivers to "make sure that upper layer actually respects BLK_FEAT_STABLE_WRITES". It's the upper layer that needs to be fixed. My opinon - we need to drop this patch, sorry.
