Re: + mm-execmem-make-arch_wants_execmem_late-depend-on-execmem.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/10/24 08:40, Andrew Morton wrote:
> 
> The patch titled
>      Subject: mm/execmem: make ARCH_WANTS_EXECMEM_LATE depend on EXECMEM
> has been added to the -mm mm-unstable branch.  Its filename is
>      mm-execmem-make-arch_wants_execmem_late-depend-on-execmem.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-execmem-make-arch_wants_execmem_late-depend-on-execmem.patch
> 
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Subject: mm/execmem: make ARCH_WANTS_EXECMEM_LATE depend on EXECMEM
> Date: Mon, 9 Dec 2024 08:42:51 +0530
> 
> Late initialisation of EXECMEM inherently requires EXECMEM itself, and
> hence this dependency should not be left with the subscribing platforms.
> 
> Link: https://lkml.kernel.org/r/20241209031251.515903-1-anshuman.khandual@xxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Kees Cook <kees@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  arch/Kconfig       |    1 +
>  arch/arm64/Kconfig |    2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/arch/arm64/Kconfig~mm-execmem-make-arch_wants_execmem_late-depend-on-execmem
> +++ a/arch/arm64/Kconfig
> @@ -113,7 +113,7 @@ config ARM64
>  	select ARCH_WANT_FRAME_POINTERS
>  	select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
>  	select ARCH_WANT_LD_ORPHAN_WARN
> -	select ARCH_WANTS_EXECMEM_LATE if EXECMEM
> +	select ARCH_WANTS_EXECMEM_LATE
>  	select ARCH_WANTS_NO_INSTR
>  	select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
>  	select ARCH_HAS_UBSAN
> --- a/arch/Kconfig~mm-execmem-make-arch_wants_execmem_late-depend-on-execmem
> +++ a/arch/Kconfig
> @@ -1058,6 +1058,7 @@ config ARCH_WANTS_MODULES_DATA_IN_VMALLO
>  
>  config ARCH_WANTS_EXECMEM_LATE
>  	bool
> +	depends on EXECMEM
>  	help
>  	  For architectures that do not allocate executable memory early on
>  	  boot, but rather require its initialization late when there is
> _
> 
> Patches currently in -mm which might be from anshuman.khandual@xxxxxxx are
> 
> mm-execmem-make-arch_wants_execmem_late-depend-on-execmem.patch
> 

Hello Andrew,

As Catalin has explained earlier on the thread, we might just need
to drop the EXECMEM dependency in the platform, and not change the
generic config definition. Hence this patch needs some change.

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index b5479c8b454c..b146372bc365 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -113,7 +113,7 @@ config ARM64
        select ARCH_WANT_FRAME_POINTERS
        select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
        select ARCH_WANT_LD_ORPHAN_WARN
-       select ARCH_WANTS_EXECMEM_LATE if EXECMEM
+       select ARCH_WANTS_EXECMEM_LATE
        select ARCH_WANTS_NO_INSTR
        select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
        select ARCH_HAS_UBSAN

- Anshuman




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux