The patch titled Subject: mm/damon/core: remove duplicate list_empty quota->goals check has been added to the -mm mm-unstable branch. Its filename is mm-damon-core-remove-duplicate-list_empty-quota-goals-check.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-damon-core-remove-duplicate-list_empty-quota-goals-check.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Honggyu Kim <honggyu.kim@xxxxxx> Subject: mm/damon/core: remove duplicate list_empty quota->goals check Daye: Mon, 25 Nov 2024 13:56:55 +0900 damos_set_effective_quota() checks quota contidions but there are some duplicate checks for quota->goals inside. This patch reduces one of if statement to simplify the esz calculation logic by setting esz as ULONG_MAX by default. Link: https://lkml.kernel.org/r/20241125184307.41746-1-sj@xxxxxxxxxx Signed-off-by: Honggyu Kim <honggyu.kim@xxxxxx> Reviewed-by: SeongJae Park <sj@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/damon/core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/mm/damon/core.c~mm-damon-core-remove-duplicate-list_empty-quota-goals-check +++ a/mm/damon/core.c @@ -1542,7 +1542,7 @@ static unsigned long damos_quota_score(s static void damos_set_effective_quota(struct damos_quota *quota) { unsigned long throughput; - unsigned long esz; + unsigned long esz = ULONG_MAX; if (!quota->ms && list_empty("a->goals)) { quota->esz = quota->sz; @@ -1564,10 +1564,7 @@ static void damos_set_effective_quota(st quota->total_charged_ns; else throughput = PAGE_SIZE * 1024; - if (!list_empty("a->goals)) - esz = min(throughput * quota->ms, esz); - else - esz = throughput * quota->ms; + esz = min(throughput * quota->ms, esz); } if (quota->sz && quota->sz < esz) _ Patches currently in -mm which might be from honggyu.kim@xxxxxx are mm-damon-core-remove-duplicate-list_empty-quota-goals-check.patch