The patch titled Subject: mm: migrate: remove unused argument vma from migrate_misplaced_folio() has been added to the -mm mm-unstable branch. Its filename is mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Donet Tom <donettom@xxxxxxxxxxxxx> Subject: mm: migrate: remove unused argument vma from migrate_misplaced_folio() Date: Tue, 26 Nov 2024 09:56:54 -0600 Commit ee86814b0562 ("mm/migrate: move NUMA hinting fault folio isolation + checks under PTL") removed the code that had used the vma argument in migrate_misplaced_folio. Since the vma argument was no longer used in migrate_misplaced_folio, this patch removes it. Link: https://lkml.kernel.org/r/20241126155655.466186-1-donettom@xxxxxxxxxxxxx Signed-off-by: Donet Tom <donettom@xxxxxxxxxxxxx> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> Reviewed-by: Zi Yan <ziy@xxxxxxxxxx> Acked-by: David Hildenbrand <david@xxxxxxxxxx> Cc: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/migrate.h | 6 ++---- mm/huge_memory.c | 2 +- mm/memory.c | 2 +- mm/migrate.c | 3 +-- 4 files changed, 5 insertions(+), 8 deletions(-) --- a/include/linux/migrate.h~mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio +++ a/include/linux/migrate.h @@ -144,16 +144,14 @@ const struct movable_operations *page_mo #ifdef CONFIG_NUMA_BALANCING int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node); -int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, - int node); +int migrate_misplaced_folio(struct folio *folio, int node); #else static inline int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node) { return -EAGAIN; /* can't migrate now */ } -static inline int migrate_misplaced_folio(struct folio *folio, - struct vm_area_struct *vma, int node) +static inline int migrate_misplaced_folio(struct folio *folio, int node) { return -EAGAIN; /* can't migrate now */ } --- a/mm/huge_memory.c~mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio +++ a/mm/huge_memory.c @@ -2002,7 +2002,7 @@ vm_fault_t do_huge_pmd_numa_page(struct spin_unlock(vmf->ptl); writable = false; - if (!migrate_misplaced_folio(folio, vma, target_nid)) { + if (!migrate_misplaced_folio(folio, target_nid)) { flags |= TNF_MIGRATED; nid = target_nid; task_numa_fault(last_cpupid, nid, HPAGE_PMD_NR, flags); --- a/mm/memory.c~mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio +++ a/mm/memory.c @@ -5625,7 +5625,7 @@ static vm_fault_t do_numa_page(struct vm ignore_writable = true; /* Migrate to the requested node */ - if (!migrate_misplaced_folio(folio, vma, target_nid)) { + if (!migrate_misplaced_folio(folio, target_nid)) { nid = target_nid; flags |= TNF_MIGRATED; task_numa_fault(last_cpupid, nid, nr_pages, flags); --- a/mm/migrate.c~mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio +++ a/mm/migrate.c @@ -2683,8 +2683,7 @@ int migrate_misplaced_folio_prepare(stru * elevated reference count on the folio. This function will un-isolate the * folio, dereferencing the folio before returning. */ -int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, - int node) +int migrate_misplaced_folio(struct folio *folio, int node) { pg_data_t *pgdat = NODE_DATA(node); int nr_remaining; _ Patches currently in -mm which might be from donettom@xxxxxxxxxxxxx are mm-migrate-removed-unused-argument-vma-from-migrate_misplaced_folio.patch