The patch titled
i386: more ioapic checks
has been removed from the -mm tree. Its filename was
i386-more-ioapic-checks.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: i386: more ioapic checks
From: Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>
Coverity reports apic numbers are being passed to functions without
checking to see if they are legal.
(This is Kernel Bugzilla #6188.)
Signed-off-by: Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>
Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Cc: Andi Kleen <ak@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
arch/i386/kernel/io_apic.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff -puN arch/i386/kernel/io_apic.c~i386-more-ioapic-checks arch/i386/kernel/io_apic.c
--- a/arch/i386/kernel/io_apic.c~i386-more-ioapic-checks
+++ a/arch/i386/kernel/io_apic.c
@@ -2265,13 +2265,17 @@ static inline void __init check_timer(vo
clear_IO_APIC_pin(0, pin1);
return;
}
- clear_IO_APIC_pin(apic1, pin1);
+ if (apic1 == -1)
+ WARN_ON_ONCE(1);
+ else
+ clear_IO_APIC_pin(apic1, pin1);
+
printk(KERN_ERR "..MP-BIOS bug: 8254 timer not connected to "
"IO-APIC\n");
}
printk(KERN_INFO "...trying to set up timer (IRQ0) through the 8259A ... ");
- if (pin2 != -1) {
+ if (pin2 != -1 && apic2 != -1) {
printk("\n..... (found pin %d) ...", pin2);
/*
* legacy devices should be connected to IO APIC #0
_
Patches currently in -mm which might be from 76306.1226@xxxxxxxxxxxxxx are
i386-more-ioapic-checks.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
