Re: + zram-clear-idle-flag-after-recompression.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (24/10/28 15:10), Andrew Morton wrote:
> Patch series "zram: IDLE flag handling fixes".
> 
> zram can wrongly preserve ZRAM_IDLE flag on its entries which can result
> in premature post-processing (writeback and recompression) of such
> entries.
> 
> 
> This patch (of 2):
> 
> Recompression should clear ZRAM_IDLE flag on the entires it has accessed,
> because otherwise some entries, specifically those for which recompression
> has failed, become immediate candidate entries for another post-processing
> (e.g.  writeback).
> 
> Consider the following case:
> - recompression marks entries IDLE every 4 hours and attempts
>   to recompress them
> - some entries are incompressible, so we keep them intact and
>   hence preserve IDLE flag
> - writeback marks entries IDLE every 8 hours and writebacks
>   IDLE entries, however we have IDLE entries left from
>   recompression, so writeback prematurely writebacks those
>   entries.
> 
> Link: https://lkml.kernel.org/r/20241028073529.1383980-1-senozhatsky@xxxxxxxxxxxx
> Link: https://lkml.kernel.org/r/20241028073529.1383980-2-senozhatsky@xxxxxxxxxxxx
> Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
> Reported-by: Shin Kawamura <kawasin@xxxxxxxxxx>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Andrew, can I please ask you to replace these patches with v2 series?
v2 comes with styles and typos fixed.

https://lore.kernel.org/linux-kernel/20241028153629.1479791-1-senozhatsky@xxxxxxxxxxxx




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux