Re: + mm-vma-the-pgoff-is-correct-if-can_merge_right-fix.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2024 at 07:41:23PM -0700, Andrew Morton wrote:
>
>The patch titled
>     Subject: mm-vma-the-pgoff-is-correct-if-can_merge_right-fix
>has been added to the -mm mm-unstable branch.  Its filename is
>     mm-vma-the-pgoff-is-correct-if-can_merge_right-fix.patch
>
>This patch will shortly appear at
>     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vma-the-pgoff-is-correct-if-can_merge_right-fix.patch
>
>This patch will later appear in the mm-unstable branch at
>    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
>Before you just go and hit "reply", please:
>   a) Consider who else should be cc'ed
>   b) Prefer to cc a suitable mailing list as well
>   c) Ideally: find the original patch on the mailing list and do a
>      reply-to-all to that, adding suitable additional cc's
>
>*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
>The -mm tree is included into linux-next via the mm-everything
>branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>and is updated there every 2-3 working days
>
>------------------------------------------------------
>From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>Subject: mm-vma-the-pgoff-is-correct-if-can_merge_right-fix
>Date: Fri Oct 25 07:39:41 PM PDT 2024
>
>remove now-unused local
>
>mm/vma.c: In function 'vma_merge_new_range':
>mm/vma.c:965:23: error: unused variable 'start' [-Werror=unused-variable]
>  965 |         unsigned long start = vmg->start;
>      |                       ^~~~~

Andrew

The removal of start usage maybe come from another patch.

If my understanding is correct, 'start' would be used to restore the state on
expansion failure.

Just reply in case it would conflict with other commit.

>Cc: Jann Horn <jannh@xxxxxxxxxx>
>Cc: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
>Cc: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
>Cc: Vlastimil Babka <vbabka@xxxxxxx>
>Cc: Wei Yang <richard.weiyang@xxxxxxxxx>
>Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>---
>
> mm/vma.c |    1 -
> 1 file changed, 1 deletion(-)
>
>--- a/mm/vma.c~mm-vma-the-pgoff-is-correct-if-can_merge_right-fix
>+++ a/mm/vma.c
>@@ -962,7 +962,6 @@ struct vm_area_struct *vma_merge_new_ran
> {
> 	struct vm_area_struct *prev = vmg->prev;
> 	struct vm_area_struct *next = vmg->next;
>-	unsigned long start = vmg->start;
> 	unsigned long end = vmg->end;
> 	bool can_merge_left, can_merge_right;
> 	bool just_expand = vmg->merge_flags & VMG_FLAG_JUST_EXPAND;
>_
>
>Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
>
>mm-consolidate-common-checks-in-hugetlb_get_unmapped_area-fix.patch
>mm-memoryc-remove-stray-newline-at-top-of-file.patch
>bootmem-stop-using-page-index-fix.patch
>mm-kasan-kmsan-copy_from-to_kernel_nofault-fix.patch
>tools-mm-free-the-allocated-memory-fix.patch
>memcg-v1-no-need-for-memcg-locking-for-mglru-fix.patch
>mm-vma-the-pgoff-is-correct-if-can_merge_right-fix.patch

-- 
Wei Yang
Help you, Help me




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux