On 2024/9/25 20:18, Matthew Wilcox wrote:
On Wed, Sep 25, 2024 at 03:05:17AM -0700, Andrew Morton wrote:
+++ a/include/linux/mm_types.h
@@ -1499,4 +1499,85 @@ enum {
/* See also internal only FOLL flags in mm/internal.h */
};
+/* mm flags */
+
+/* core dumpable occupy bit0 and bit1 */
... but why is that important?
/*
* The first two bits represent core dump modes for set-user-ID,
* the modes are SUID_DUMP_* defined in linux/sched/coredump.h
*/
Do you think if change it to this will be OK?
+#define MMF_DUMPABLE_BITS 2
+#define MMF_DUMPABLE_MASK ((1 << MMF_DUMPABLE_BITS) - 1)
+++ a/include/linux/sched/coredump.h
@@ -8,12 +8,6 @@
#define SUID_DUMP_USER 1 /* Dump as user of process */
#define SUID_DUMP_ROOT 2 /* Dump as root */
-/* mm flags */
-
-/* for SUID_DUMP_* above */
the old comment told us why!
-#define MMF_DUMPABLE_BITS 2
-#define MMF_DUMPABLE_MASK ((1 << MMF_DUMPABLE_BITS) - 1)
NAK this patch.
.
