The patch titled
Subject: lib: devres: simplify API devm_iounmap() implementation
has been added to the -mm mm-nonmm-unstable branch. Its filename is
lib-devres-simplify-api-devm_iounmap-implementation.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/lib-devres-simplify-api-devm_iounmap-implementation.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
Subject: lib: devres: simplify API devm_iounmap() implementation
Date: Wed, 18 Sep 2024 22:48:13 +0800
Patch series "lib: devres: Simplify both API devm_iounmap() and
devm_ioport_unmap() implementation".
This patch series is to simplify implementation for both API
devm_iounmap() and devm_ioport_unmap().
This patch (of 2):
Simplify devm_iounmap() implementation by dedicated API devres_release()
compared with current solution, namely, devres_destroy() + iounmap()
devres_release() has the following advantages:
- it is simpler if devm_iounmap()'s parameter @addr is valid, namely
@addr was ever returned by one of devm_ioremap() variants.
- it can avoid unnecessary iounmap(@addr) if @addr is not valid.
Link: https://lkml.kernel.org/r/20240918-fix_lib_devres-v1-0-e696ab5486e6@xxxxxxxxxxx
Link: https://lkml.kernel.org/r/20240918-fix_lib_devres-v1-1-e696ab5486e6@xxxxxxxxxxx
Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Zijun Hu <zijun_hu@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/devres.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/lib/devres.c~lib-devres-simplify-api-devm_iounmap-implementation
+++ a/lib/devres.c
@@ -115,9 +115,8 @@ EXPORT_SYMBOL(devm_ioremap_wc);
*/
void devm_iounmap(struct device *dev, void __iomem *addr)
{
- WARN_ON(devres_destroy(dev, devm_ioremap_release, devm_ioremap_match,
+ WARN_ON(devres_release(dev, devm_ioremap_release, devm_ioremap_match,
(__force void *)addr));
- iounmap(addr);
}
EXPORT_SYMBOL(devm_iounmap);
_
Patches currently in -mm which might be from quic_zijuhu@xxxxxxxxxxx are
lib-devres-simplify-api-devm_iounmap-implementation.patch
lib-devres-simplify-api-devm_ioport_unmap-implementation.patch
