+ cciss-fix-xfer_read-xfer_write-in-do_cciss_request.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     cciss: fix XFER_READ/XFER_WRITE in do_cciss_request
has been added to the -mm tree.  Its filename is
     cciss-fix-xfer_read-xfer_write-in-do_cciss_request.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: cciss: fix XFER_READ/XFER_WRITE in do_cciss_request
From: Mike Miller <mike.miller@xxxxxx>

Fix a stupid bug.  Sometime during the 2tb enhancement I ended up replacing
the macros XFER_READ and XFER_WRITE with h->cciss_read and h->cciss_write
respectively.  It seemed to work somehow at least on x86_64 and ia64.  I don't
know how.  But people started complaining about command timeouts on older
controllers like the 64xx series and only on ia32.  This resolves the issue
reproduced in our lab.  Please consider this for inclusion.

Signed-off-by: Mike Miller <mike.miller@xxxxxx>
Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/block/cciss.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/block/cciss.c~cciss-fix-xfer_read-xfer_write-in-do_cciss_request drivers/block/cciss.c
--- a/drivers/block/cciss.c~cciss-fix-xfer_read-xfer_write-in-do_cciss_request
+++ a/drivers/block/cciss.c
@@ -2492,7 +2492,7 @@ static void do_cciss_request(request_que
 	c->Request.Type.Type = TYPE_CMD;	// It is a command.
 	c->Request.Type.Attribute = ATTR_SIMPLE;
 	c->Request.Type.Direction =
-	    (rq_data_dir(creq) == READ) ? h->cciss_read : h->cciss_write;
+	    (rq_data_dir(creq) == READ) ? XFER_READ : XFER_WRITE;
 	c->Request.Timeout = 0;	// Don't time out
 	c->Request.CDB[0] =
 	    (rq_data_dir(creq) == READ) ? h->cciss_read : h->cciss_write;
_

Patches currently in -mm which might be from mike.miller@xxxxxx are

cciss-set-default-raid-level-when-reading-geometry-fails.patch
cciss-fix-xfer_read-xfer_write-in-do_cciss_request.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux