On Tue, Sep 3, 2024 at 12:53 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 3 Sep 2024 10:53:21 -0700 Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > > > The inconsistency became more noticeable after I introduced the > > > MemoryZSwapWriteback= systemd unit setting [2] for controlling the knob. > > > The patch assumed that the kernel would enforce the value of parent > > > cgroups. It could probably be workarounded from systemd's side, by going > > > up the slice unit tree and inheriting the value. Yet I think it's more > > > sensible to make it behave consistently with zswap.max and friends. > > > > > > [1] https://wiki.archlinux.org/title/Power_management/Suspend_and_hibernate#Disable_zswap_writeback_to_use_the_swap_space_only_for_hibernation > > > [2] https://github.com/systemd/systemd/pull/31734 > > > > > > Link: https://lkml.kernel.org/r/20240823162506.12117-1-me@xxxxxxxxxxx > > > Fixes: 501a06fe8e4c ("zswap: memcontrol: implement zswap writeback disabling") > > > Signed-off-by: Mike Yuan <me@xxxxxxxxxxx> > > > Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx> > > > Acked-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > > > > We wanted to CC stable here, it's too late at this point, right? > > It has cc:stable? > > > > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > > > Cc: Michal Hocko <mhocko@xxxxxxxxxx> > > > Cc: Michal Koutný <mkoutny@xxxxxxxx> > > > Cc: Muchun Song <muchun.song@xxxxxxxxx> > > > Cc: Roman Gushchin <roman.gushchin@xxxxxxxxx> > > > Cc: Shakeel Butt <shakeel.butt@xxxxxxxxx> > > > Cc: <stable@xxxxxxxxxxxxxxx> > > ^^ here Sorry for the noise, I'll go find an eye doctor.
