On Wed, Aug 28, 2024 at 02:27:00AM GMT, Andrew Morton wrote:
> On Wed, 28 Aug 2024 09:33:15 +0100 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:
>
> > > +#ifdef CONFIG_MMU
> > > /*
> > > * These three helpers classifies VMAs for virtual memory accounting.
> > > */
> > > @@ -255,6 +256,7 @@ static inline bool is_data_mapping(vm_fl
> > > {
> > > return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE;
> > > }
> > > +#endif
> > >
> >
> > Something's gone horribly wrong here! This ifdef is not meant to be here
> > but rather around init_vma_munmap() as shown in fix patch in [0].
> >
> > I'm not sure how the patch got mangled like this.
> >
> > Could we replace this bogus patch with the correct one? Thanks!
> >
> >
> > [0]: https://lore.kernel.org/all/7d0ea994-f750-49c5-b392-ae7117369cf3@lucifer.local/
>
> afaict this is a fix against "mm/vma: expand mmap_region() munmap
> call", so applying it against "mm: remove duplicated include in
> vma_internal.h" made everything go pear-shaped.
>
Yeah sorry, this is my bad for not putting the fix next to the appropriate
patch and just linking that from the report. Have done that for other such
cases and will do that going forward to make life easier :)
