The patch titled Subject: mm-zswap-use-only-one-pool-in-zswap-v3 has been added to the -mm mm-unstable branch. Its filename is mm-zswap-use-only-one-pool-in-zswap-v3.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-zswap-use-only-one-pool-in-zswap-v3.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Chengming Zhou <chengming.zhou@xxxxxxxxx> Subject: mm-zswap-use-only-one-pool-in-zswap-v3 Date: Tue, 25 Jun 2024 12:39:05 +0800 fix error handling again in zswap_pool_create(), per Yosry Link: https://lkml.kernel.org/r/20240625-zsmalloc-lock-mm-everything-v3-2-ad941699cb61@xxxxxxxxx Signed-off-by: Chengming Zhou <chengming.zhou@xxxxxxxxx> Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx> Cc: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Minchan Kim <minchan@xxxxxxxxxx> Cc: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> Cc: Yosry Ahmed <yosryahmed@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/zswap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/mm/zswap.c~mm-zswap-use-only-one-pool-in-zswap-v3 +++ a/mm/zswap.c @@ -268,7 +268,7 @@ static struct zswap_pool *zswap_pool_cre pool->zpool = zpool_create_pool(type, name, gfp); if (!pool->zpool) { pr_err("%s zpool not available\n", type); - return NULL; + goto error; } pr_debug("using %s zpool\n", zpool_get_type(pool->zpool)); @@ -303,7 +303,8 @@ ref_fail: error: if (pool->acomp_ctx) free_percpu(pool->acomp_ctx); - zpool_destroy_pool(pool->zpool); + if (pool->zpool) + zpool_destroy_pool(pool->zpool); kfree(pool); return NULL; } _ Patches currently in -mm which might be from chengming.zhou@xxxxxxxxx are mm-zswap-use-only-one-pool-in-zswap.patch mm-zswap-use-only-one-pool-in-zswap-v2.patch mm-zswap-use-only-one-pool-in-zswap-v3.patch mm-ksm-refactor-out-try_to_merge_with_zero_page.patch mm-ksm-dont-waste-time-searching-stable-tree-for-fast-changing-page.patch mm-ksm-optimize-the-chain-chain_prune-interfaces.patch