Re: + mm-arm64-fix-the-out-of-bounds-issue-in-contpte_clear_young_dirty_ptes.patch added to mm-hotfixes-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

On Fri, May 24, 2024 at 12:10:53PM -0700, Andrew Morton wrote:
> The patch titled
>      Subject: mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty_ptes
> has been added to the -mm mm-hotfixes-unstable branch.  Its filename is
>      mm-arm64-fix-the-out-of-bounds-issue-in-contpte_clear_young_dirty_ptes.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-arm64-fix-the-out-of-bounds-issue-in-contpte_clear_young_dirty_ptes.patch
> 
> This patch will later appear in the mm-hotfixes-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Barry Song <v-songbaohua@xxxxxxxx>
> Subject: mm: arm64: Fix the out-of-bounds issue in contpte_clear_young_dirty_ptes
> Date: Fri, 24 May 2024 12:54:44 +1200
> 
> We are passing a huge nr to __clear_young_dirty_ptes() right now.  While
> we should pass the number of pages, we are actually passing CONT_PTE_SIZE.
> This is causing lots of crashes of MADV_FREE, panic oops could vary
> everytime.
> 
> Link: https://lkml.kernel.org/r/20240524005444.135417-1-21cnbao@xxxxxxxxx
> Fixes: 89e86854fb0a ("mm/arm64: override clear_young_dirty_ptes() batch helper")
> Signed-off-by: Barry Song <v-songbaohua@xxxxxxxx>
> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> Acked-by: Lance Yang <ioworker0@xxxxxxxxx>
> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
> Acked-by: Chris Li <chrisl@xxxxxxxxxx>
> Cc: Barry Song <21cnbao@xxxxxxxxx>
> Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
> Cc: Jeff Xie <xiehuan09@xxxxxxxxx>
> Cc: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Cc: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> Cc: Peter Xu <peterx@xxxxxxxxxx>
> Cc: Yang Shi <shy828301@xxxxxxxxx>
> Cc: Yin Fengwei <fengwei.yin@xxxxxxxxx>
> Cc: Zach O'Keefe <zokeefe@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  arch/arm64/mm/contpte.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I was hoping that this would land in -rc2 to keep the testing bots at
bay, but it looks like it's still not graduated out of -next.

Did it simply fall by the wayside this time around, or are you waiting
for us to do something on the arm64 side? I can pick it up for -rc3 if
it makes life easier for you. Please let me know.

Cheers,

Will




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux